Make router prettier

This commit is contained in:
Henrique Dias 2016-10-18 22:00:26 +01:00
parent fe7579966d
commit 9f9a6254e5
1 changed files with 109 additions and 98 deletions

View File

@ -39,128 +39,139 @@ func (f FileManager) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, err
) )
for i := range f.Configs { for i := range f.Configs {
if httpserver.Path(r.URL.Path).Matches(f.Configs[i].BaseURL) { // Checks if this Path should be handled by File Manager.
c = &f.Configs[i] if !httpserver.Path(r.URL.Path).Matches(f.Configs[i].BaseURL) {
return f.Next.ServeHTTP(w, r)
}
if r.Method == http.MethodGet && httpserver.Path(r.URL.Path).Matches(c.BaseURL+assets.BaseURL) { c = &f.Configs[i]
// Checks if the URL matches the Assets URL. Returns the asset if the
// method is GET and Status Forbidden otherwise.
if httpserver.Path(r.URL.Path).Matches(c.BaseURL + assets.BaseURL) {
if r.Method == http.MethodGet {
return assets.Serve(w, r, c) return assets.Serve(w, r, c)
} }
username, _, _ := r.BasicAuth() return http.StatusForbidden, nil
}
if _, ok := c.Users[username]; ok { // Obtains the user
user = c.Users[username] username, _, _ := r.BasicAuth()
} else { if _, ok := c.Users[username]; ok {
user = c.User user = c.Users[username]
} } else {
user = c.User
if strings.HasPrefix(r.URL.Path, c.WebDavURL) { }
if !user.Allowed(strings.TrimPrefix(r.URL.Path, c.WebDavURL)) {
return http.StatusForbidden, nil
}
switch r.Method {
case "PROPPATCH", "MOVE", "PATCH", "PUT", "DELETE":
if !user.AllowEdit {
return http.StatusForbidden, nil
}
case "MKCOL", "COPY":
if !user.AllowNew {
return http.StatusForbidden, nil
}
}
if r.Method == http.MethodPut {
_, err = processPUT(w, r, c, user, fi)
if err != nil {
return http.StatusInternalServerError, err
}
}
c.Handler.ServeHTTP(w, r)
return 0, nil
}
if !user.Allowed(strings.TrimPrefix(r.URL.Path, c.BaseURL)) {
if r.Method == http.MethodGet {
return page.PrintErrorHTML(
w,
http.StatusForbidden,
e.New("You don't have permission to access this page."),
)
}
// Checks if the request URL is for the WebDav server
if strings.HasPrefix(r.URL.Path, c.WebDavURL) {
// Checks for user permissions relatively to this PATH
if !user.Allowed(strings.TrimPrefix(r.URL.Path, c.WebDavURL)) {
return http.StatusForbidden, nil return http.StatusForbidden, nil
} }
switch r.Method {
case "PROPPATCH", "MOVE", "PATCH", "PUT", "DELETE":
if !user.AllowEdit {
return http.StatusForbidden, nil
}
case "MKCOL", "COPY":
if !user.AllowNew {
return http.StatusForbidden, nil
}
}
// Preprocess the PUT request if it's the case
if r.Method == http.MethodPut {
_, err = processPUT(w, r, c, user, fi)
if err != nil {
return http.StatusInternalServerError, err
}
}
c.Handler.ServeHTTP(w, r)
return 0, nil
}
// Checks if the User is allowed to access this file
if !user.Allowed(strings.TrimPrefix(r.URL.Path, c.BaseURL)) {
if r.Method == http.MethodGet { if r.Method == http.MethodGet {
// Gets the information of the directory/file return page.PrintErrorHTML(
fi, code, err = file.GetInfo(r.URL, c, user) w, http.StatusForbidden,
if err != nil { e.New("You don't have permission to access this page."),
if r.Method == http.MethodGet { )
return page.PrintErrorHTML(w, code, err) }
}
return code, err
}
// If it's a dir and the path doesn't end with a trailing slash, return http.StatusForbidden, nil
// redirect the user. }
if fi.IsDir() && !strings.HasSuffix(r.URL.Path, "/") {
http.Redirect(w, r, c.AddrPath+r.URL.Path+"/", http.StatusTemporaryRedirect)
return 0, nil
}
// Generate anti security token. if r.Method == http.MethodGet {
c.GenerateToken() // Gets the information of the directory/file
fi, code, err = file.GetInfo(r.URL, c, user)
if !fi.IsDir() { if err != nil {
query := r.URL.Query() if r.Method == http.MethodGet {
if val, ok := query["raw"]; ok && val[0] == "true" {
r.URL.Path = strings.Replace(r.URL.Path, c.BaseURL, c.WebDavURL, 1)
c.Handler.ServeHTTP(w, r)
return 0, nil
}
if val, ok := query["download"]; ok && val[0] == "true" {
w.Header().Set("Content-Disposition", "attachment; filename="+fi.Name())
r.URL.Path = strings.Replace(r.URL.Path, c.BaseURL, c.WebDavURL, 1)
c.Handler.ServeHTTP(w, r)
return 0, nil
}
}
code, err := fi.ServeHTTP(w, r, c, user)
if err != nil {
return page.PrintErrorHTML(w, code, err) return page.PrintErrorHTML(w, code, err)
} }
return code, err return code, err
} }
if r.Method == http.MethodPost { // If it's a dir and the path doesn't end with a trailing slash,
// TODO: How to exclude web dav clients? :/ // redirect the user.
// Security measures against CSRF attacks. if fi.IsDir() && !strings.HasSuffix(r.URL.Path, "/") {
if !c.CheckToken(r) { http.Redirect(w, r, c.AddrPath+r.URL.Path+"/", http.StatusTemporaryRedirect)
return http.StatusForbidden, nil return 0, nil
}
// Generate anti security token.
c.GenerateToken()
if !fi.IsDir() {
query := r.URL.Query()
webdav := false
if val, ok := query["raw"]; ok && val[0] == "true" {
webdav = true
} }
/* TODO: search commands. USE PROPFIND? if val, ok := query["download"]; ok && val[0] == "true" {
// Search and git commands. w.Header().Set("Content-Disposition", "attachment; filename="+fi.Name())
if r.Header.Get("Search") == "true" { webdav = true
}
} */ if webdav {
r.URL.Path = strings.Replace(r.URL.Path, c.BaseURL, c.WebDavURL, 1)
// VCS commands. c.Handler.ServeHTTP(w, r)
if r.Header.Get("Command") != "" { return 0, nil
if !user.AllowCommands {
return http.StatusUnauthorized, nil
}
return command(w, r, c, user)
} }
} }
return http.StatusNotImplemented, nil code, err := fi.ServeHTTP(w, r, c, user)
if err != nil {
return page.PrintErrorHTML(w, code, err)
}
return code, err
} }
if r.Method == http.MethodPost {
// TODO: This anti CSCF measure is not being applied to requests
// to the WebDav URL namespace. Anyone has ideas?
if !c.CheckToken(r) {
return http.StatusForbidden, nil
}
// VCS commands.
if r.Header.Get("Command") != "" {
if !user.AllowCommands {
return http.StatusUnauthorized, nil
}
return command(w, r, c, user)
}
}
return http.StatusNotImplemented, nil
} }
return f.Next.ServeHTTP(w, r) return f.Next.ServeHTTP(w, r)