From 56df9903e103127b508d3c4f9e0a8e293a4a6804 Mon Sep 17 00:00:00 2001 From: soylent Date: Wed, 20 Mar 2019 15:58:19 -0600 Subject: [PATCH] Fix exception when API desc doesn't contain blacklisted params (#768) --- lib/google/apis/generator/model.rb | 2 +- spec/google/apis/generator/generator_spec.rb | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/google/apis/generator/model.rb b/lib/google/apis/generator/model.rb index 30f381c61..1d5c26891 100644 --- a/lib/google/apis/generator/model.rb +++ b/lib/google/apis/generator/model.rb @@ -163,7 +163,7 @@ module Google end def parameters - Hash[(@parameters || {}).sort].reject! { |k, _v| PARAMETER_BLACKLIST.include?(k) } + Hash[(@parameters || {}).sort].delete_if { |k, _v| PARAMETER_BLACKLIST.include?(k) } end def schemas diff --git a/spec/google/apis/generator/generator_spec.rb b/spec/google/apis/generator/generator_spec.rb index b4ea450ba..26c4efbb1 100644 --- a/spec/google/apis/generator/generator_spec.rb +++ b/spec/google/apis/generator/generator_spec.rb @@ -326,4 +326,22 @@ EOF end end end + + context 'with minimal API description' do + before do + generated_files = Google::Apis::Generator.new.render( + '{ "name": "minimal_api", "id": "minimal_api", "version": "v1" }' + ) + + namespace.send(:binding).eval( + generated_files.fetch('google/apis/minimal_api_v1/service.rb') + ) + end + + let(:namespace) { Module.new } + + it 'should define service class' do + expect(namespace).to be_const_defined('Google::Apis::MinimalApiV1::MinimalApiService') + end + end end