From e0afbdaf059ceaf3a1897b04bf4466438824b262 Mon Sep 17 00:00:00 2001 From: Bob Aman Date: Wed, 16 Nov 2011 11:44:44 +0300 Subject: [PATCH] Attempting to fix some Windows issues and update deprecated library calls. --- bin/google-api | 9 ++++----- lib/google/api_client/environment.rb | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/bin/google-api b/bin/google-api index c6e641113..e8f395766 100755 --- a/bin/google-api +++ b/bin/google-api @@ -294,13 +294,12 @@ HTML exit(0) else $verifier = nil - # TODO(bobaman): Cross-platform? - logger = WEBrick::Log.new('/dev/null') server = WEBrick::HTTPServer.new( :Port => OAUTH_SERVER_PORT, - :Logger => logger, - :AccessLog => logger + :Logger => WEBrick::Log.new, + :AccessLog => WEBrick::Log.new ) + server.logger.level = 0 trap("INT") { server.shutdown } server.mount("/", OAuthVerifierServlet) @@ -389,7 +388,7 @@ HTML ) # Launch browser - Launchy::Browser.run(oauth_client.authorization_uri.to_s) + Launchy.open(oauth_client.authorization_uri.to_s) server.start oauth_client.code = $verifier diff --git a/lib/google/api_client/environment.rb b/lib/google/api_client/environment.rb index 7bb7966cf..dbdb2d8eb 100644 --- a/lib/google/api_client/environment.rb +++ b/lib/google/api_client/environment.rb @@ -5,7 +5,7 @@ module Google # TODO(bobaman) # Confirm that all of these Windows environments actually have access # to the `ver` command. - `ver`.sub(/\s*\[Version\s*/, '/').sub(']', '') + `ver`.sub(/\s*\[Version\s*/, '/').sub(']', '').strip elsif RUBY_PLATFORM =~ /darwin/i "Mac OS X/#{`sw_vers -productVersion`}" else