Avoid memoizing network-related false negatives of GCECredentials.on_gce? (#137)

2018-06-06 07:20:36 +09:00 · 2018-06-06 07:20:36 +09:00 · edaa784d3d
parent 9232aa3176
commit edaa784d3d
1 changed files with 5 additions and 1 deletions
--- a/lib/googleauth/application_default.rb
+++ b/lib/googleauth/application_default.rb
@ -58,7 +58,11 @@ ERROR_MESSAGE
              DefaultCredentials.from_well_known_path(scope) ||
              DefaultCredentials.from_system_default_path(scope)
      return creds unless creds.nil?
-      raise NOT_FOUND_ERROR unless GCECredentials.on_gce?(options)
+      unless GCECredentials.on_gce?(options)
+        # Clear cache of the result of GCECredentials.on_gce?
+        GCECredentials.unmemoize_all
+        raise NOT_FOUND_ERROR
+      end
      GCECredentials.new
    end