chiu
/
impressionist
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #242 from charlotte-ruby/performance-deletion 

Performance deletion
This commit is contained in:
Jonas Grau 2017-05-24 21:50:14 +02:00 committed by GitHub
parent 529f9d494d e94e8cf413
commit 72b379908f
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/impressionist/is_impressionable.rb
View File

@ -15,7 +15,7 @@ module Impressionist
def define_association def define_association
has_many(:impressions, has_many(:impressions,
:as => :impressionable, :as => :impressionable,
:dependent => :destroy) :dependent => :delete_all)
end end
end end

2
lib/impressionist/models/mongo_mapper/impressionist/impressionable.rb
View File

@ -9,7 +9,7 @@ module Impressionist
def is_impressionable(options={}) def is_impressionable(options={})
many(:impressions, many(:impressions,
:as => :impressionable, :as => :impressionable,
:dependent => :destroy) :dependent => :delete_all)
@impressionist_cache_options = options @impressionist_cache_options = options
end end

4
tests/test_app/spec/models/model_spec.rb
View File

@ -57,14 +57,14 @@ describe Impression do
@article.impressionist_count(:filter=>:session_hash).should eq 7 @article.impressionist_count(:filter=>:session_hash).should eq 7
end end
# tests :dependent => :destroy # tests :dependent => :delete_all
it "should delete impressions on deletion of impressionable" do it "should delete impressions on deletion of impressionable" do
#impressions_count = Impression.all.size #impressions_count = Impression.all.size
a = Article.create a = Article.create
i = a.impressions.create i = a.impressions.create
a.destroy a.destroy
a.destroyed?.should be_true a.destroyed?.should be_true
i.destroyed?.should be_true Impression.exists?(i.id).should be_false
end end
end end