From e5566fad8a28699d99fbed181b0b55fe8e1136b0 Mon Sep 17 00:00:00 2001 From: Kai Schlichting Date: Thu, 19 Jan 2012 21:27:36 +0100 Subject: [PATCH] speedup unique impressions by using "Impression#exists?" instead of "#Impression#size == 0" --- app/controllers/impressionist_controller.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/impressionist_controller.rb b/app/controllers/impressionist_controller.rb index 1b74eb2..15a87df 100644 --- a/app/controllers/impressionist_controller.rb +++ b/app/controllers/impressionist_controller.rb @@ -48,11 +48,11 @@ module ImpressionistController end def unique_instance?(impressionable, unique_opts) - return unique_opts.blank? || impressionable.impressions.where(unique_query(unique_opts)).size == 0 + return unique_opts.blank? || !impressionable.impressions.where(unique_query(unique_opts)).exists? end def unique?(unique_opts) - return unique_opts.blank? || Impression.where(unique_query(unique_opts)).size == 0 + return unique_opts.blank? || !Impression.where(unique_query(unique_opts)).exists? end # creates the query to check for uniqueness