Merge pull request #70 from tyrauber/non-restful-controller-support

Non-restful controller support

lib/impressionist/models/active_record/impression.rb

@@ -10,11 +10,12 @@ class Impression < ActiveRecord::Base
   private
 
   def update_impressions_counter_cache
-    impressionable_class = self.impressionable_type.constantize
+    if self.impressionable_type && self.impressionable_id
-
+      impressionable_class = self.impressionable_type.constantize
-    if impressionable_class.impressionist_counter_cache_options
+      if impressionable_class.impressionist_counter_cache_options
-      resouce = impressionable_class.find(self.impressionable_id)
+        resouce = impressionable_class.find(self.impressionable_id)
-      resouce.try(:update_impressionist_counter_cache)
+        resouce.try(:update_impressionist_counter_cache)
+      end
     end
   end
 end

test_app/app/controllers/dummy_controller.rb

@@ -3,4 +3,6 @@ class DummyController < ActionController::Base
 
   impressionist
 
+  def index
+  end
 end

test_app/config/routes.rb

@@ -1,3 +1,3 @@
 TestApp::Application.routes.draw do
-  resources :articles, :posts, :widgets
+  resources :articles, :posts, :widgets, :dummy
 end

test_app/spec/controllers/controller_spec.rb

@@ -123,3 +123,12 @@ describe WidgetsController do
   end
 
 end
+describe DummyController do
+  fixtures :impressions
+  render_views
+
+  it "should log impression at the per action level on non-restful controller" do
+    get "index"
+    Impression.all.size.should eq 12
+  end
+end