chiu
/
impressionist
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #243 from charlotte-ruby/fix-counter-cache-not-updating 

Fix counter cache not updating when no `unique` option is set
This commit is contained in:
Jonas Grau 2017-05-24 21:50:37 +02:00 committed by GitHub
parent 72b379908f e8b4700783
commit dab5ffce83
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/impressionist/impressionable.rb
View File

@ -8,7 +8,7 @@ module Impressionist
DEFAULT_CACHE ||= { DEFAULT_CACHE ||= {
:counter_cache => false, :counter_cache => false,
:column_name => :impressions_count, :column_name => :impressions_count,
:unique => false :unique => :all
} }
def impressionist_counter_cache_options def impressionist_counter_cache_options

14
lib/impressionist/update_counters.rb
View File

@ -42,9 +42,17 @@ module Impressionist
# is_impressionable :counter_cache => true, # is_impressionable :counter_cache => true,
# :unique => :any_other_filter # :unique => :any_other_filter
def unique_filter def unique_filter
Symbol === unique ? # Support `is_impressionable :counter_cache => true, :unique => true`
unique : # defaulting to `:ip_address` for counting unique impressions.
:ip_address return :ip_address if unique == true
# Should a user try `is_impressionable :counter_cache => true, :unique => false`
# then support that as well
return :all if unique == false
# Otherwise set the filter to either what the user supplied as the `unique` option
# or the default (`:all`)
unique
end end
def unique def unique