Commit Graph

432 Commits

Author SHA1 Message Date
John McAliley ce935aaa38 change controller_path back to controller_name
This is causing missing constant errors for people who are upgrading
2013-05-07 21:40:59 -03:00
johnmcaliley ef34cf85b8 bump version to 1.3.0 2013-05-06 09:57:13 -04:00
John McAliley 89913641bc Update create_impressions_table.rb
add length for message
2013-05-06 10:30:26 -03:00
John McAliley 3821a7f0ba Merge pull request #75 from nbit001/cleaner_engine
Cleaner engine
2013-05-06 06:22:12 -07:00
Nalesso Moreira 1f25e16c0e Update engine.rb
I've done a bit more of refactoring.
2013-05-06 05:27:10 +02:00
nbit001 14f4097a7b Removed conditional statements and following the DRY concept. 2013-05-05 21:53:04 +01:00
nbit001 aad703c297 Removed conditional statements and following the DRY concept. 2013-05-05 21:47:41 +01:00
John McAliley 23ce2b201e fix spec and use controller_path in mongoid 2013-04-01 22:40:09 -04:00
John McAliley a6e8ac2418 remove jruby from travis 2013-04-01 22:05:47 -04:00
John McAliley 26835a237b Merge pull request #71 from yous/fix_unique_impressionable_type
Fix uniqueness of impressionable_type
2013-04-01 18:59:31 -07:00
John McAliley 4a7532f69b Merge pull request #68 from FoboCasteR/fix-issue-60
fix filter for mongoid (Fix #60)
2013-04-01 18:52:46 -07:00
John McAliley 48b3819764 Update README.md 2013-04-01 22:39:56 -03:00
John McAliley d3a52b18cf Merge pull request #70 from tyrauber/non-restful-controller-support
Non-restful controller support
2013-04-01 12:56:14 -07:00
ChaYoung You df8489163e Change generating impressionable_type by from controller_name to controller_path 2013-04-01 04:19:24 +09:00
Ty Rauber 495e0a4273 Test coverage around impressions for non-restful controller actions. Added dummy route, index method, view and dummy controller spec. 2013-03-30 13:30:56 -07:00
Ty Rauber 39c217a976 Non-restful controllers - controllers without models / resources - would cause impressionist to throw an error on impression create, because it was unable to update the model counter cache due to lack of an impressionable_type and impressionable_id. An if statement around the counter-cache method on impressionable_type and impressionable_id solves this. 2013-03-30 13:00:46 -07:00
FoboCasteR 7431129092 fix filter for mongoid (Fix #60) 2013-03-25 12:00:16 +03:00
John McAliley 27c9352a5e Merge pull request #66 from AdamFerguson/master
Remove message index
2013-03-23 18:42:18 -07:00
Adam Ferguson abe0b8790a remove migration to index impressionable_type, message, and impressionable_id 2013-03-04 14:46:29 -05:00
John McAliley d5f29fe825 Merge pull request #64 from hyperrjas/master
how add mongoid on README.MD
2013-02-28 20:05:49 -08:00
hyperrjas 56c442bee0 Update README.md 2013-02-28 13:17:54 +01:00
hyperrjas fd5b4ee6f2 how add mongoid on README.MD
I have added a brief explanation of how to work with Mongoid odm instead of ActiveRecord

Thank  you!
2013-02-28 13:16:43 +01:00
John McAliley 0894f6a550 travis jruby19 2013-02-19 16:19:13 -05:00
John McAliley 686d12f2d3 force rails generator file overwrite 2013-02-19 15:58:30 -05:00
John McAliley a3f8dfd373 update to v1.2.0 2013-02-19 15:40:24 -05:00
John McAliley 9f9ed8fb87 Merge pull request #53 from elfassy/master
Fix model inconsistency
2013-02-19 12:22:27 -08:00
John McAliley bbb142a968 Update README.md
wink
2013-01-17 16:23:50 -05:00
Michael Elfassy 00e658b28d fix for bug undefined method 'belongs_to' for Impression:Class 2012-10-10 12:03:18 -04:00
John McAliley 7a93fff255 Merge pull request #46 from jgwmaxwell/mongoid
Mongoid Support
2012-07-19 08:39:13 -07:00
JGW Maxwell 8f2c219b97 removed more files 2012-07-11 10:33:35 +01:00
JGW Maxwell 7eae7fb1d0 removed unneeded file 2012-07-11 03:45:55 +01:00
JGW Maxwell 2f8c47a46f fixed for Mongoid 2 support 2012-07-11 03:45:24 +01:00
JGW Maxwell a53363d9f6 Fixed default ActiveRecord setting preventing generator from running. 2012-07-11 02:58:59 +01:00
JGW Maxwell 7ab364c7eb Mongoid functionality working for Mongoid 3.0, haven't got to grips with the tests yet, so will push those in next commit 2012-07-11 02:42:43 +01:00
Erik Michaels-Ober bdd7a05215 Merge pull request #44 from c42engineering/master
Avoid updating updated_at when counter_cache column is updated.
2012-07-04 12:04:12 -07:00
Asif S Kalam 9104ddb7b7 Avoid updating timestamp when updating counter_cache. 2012-07-04 19:53:25 +05:30
Erik Michaels-Ober b6c67f2abe Remove executable attributes and shebang line 2012-05-07 13:44:01 -07:00
Erik Michaels-Ober d1032cb93e Test against MRI 2.0 2012-04-24 02:24:00 -07:00
Erik Michaels-Ober 90d9428687 Remove .DS_Store from .gitignore
This should be in a (Mac) user's ~/.gitignore_global
2012-04-16 18:11:25 -07:00
Adam Ferguson 92e2147f61 remove_index not remove_column 2012-04-03 15:29:21 -04:00
Adam Ferguson a773a4d366 Add compound index on impressionable_type, message, impressionable_id 2012-04-03 15:23:14 -04:00
Erik Michaels-Ober 63ea4d5663 Merge pull request #36 from challengepost/namespace_impressionable_methods
Namespace impressionable methods
2012-03-21 12:48:51 -07:00
Erik Michaels-Ober 95125f4627 Merge pull request #37 from challengepost/optimize_impressionist_count
Optimize impressionist_count query via arel count with distinct option
2012-03-21 12:47:18 -07:00
Erik Michaels-Ober 6e6016480b Remove JRuby in 1.9 mode from the test matrix
The tests depend on at least one gem with native extensions (sqlite)
that won't build on JRuby in 1.9 mode. :(
2012-03-21 11:11:07 -07:00
Erik Michaels-Ober 69b01ca270 Merge pull request #38 from challengepost/bot_method
bot? method
2012-03-21 10:58:50 -07:00
Ross Kaffenberger 3a64d4b9ab Add extract controller logic for bypassing impression to bot? method 2012-03-20 17:04:00 -04:00
Ross Kaffenberger fcfacdfdc9 Optimize impressionist_count query via arel count with distinct option 2012-03-19 18:27:41 -04:00
Ross Kaffenberger 51144d4c86 Typo in test 2012-03-19 16:04:43 -04:00
Ross Kaffenberger f59f897d25 Deprecation warning for counter_caching? 2012-03-19 15:56:42 -04:00
Ross Kaffenberger 4c2c09ca69 Rename instance method update_counter_cache => update_impressionist_counter_cache 2012-03-19 14:33:19 -04:00