core
/
gitea
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only hide tooltip tippy instances (#24688) 

Fix regression from https://github.com/go-gitea/gitea/pull/24648 where
it was hiding non-tooltip tippy instances, like for example in the
review panel which itself is a tippy instance, but with a different
`role`.
This commit is contained in:
silverwind 2023-05-12 18:58:55 +02:00 committed by GitHub
parent b20e5f9cd8
commit 80bde0141b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web_src/js/modules/tippy.js
View File

@ -18,8 +18,11 @@ export function createTippy(target, opts = {}) {
visibleInstances.delete(instance); visibleInstances.delete(instance);
}, },
onShow: (instance) => { onShow: (instance) => {
// hide other tooltip instances so only one tooltip shows at a time
for (const visibleInstance of visibleInstances) { for (const visibleInstance of visibleInstances) {
visibleInstance.hide(); // hide other instances if (visibleInstance.role === 'tooltip') {
visibleInstance.hide();
}
} }
visibleInstances.add(instance); visibleInstances.add(instance);
}, },