git migration: don't prompt interactively for clone credentials (#15902)
* don't prompt interactively for clone credentials * apply GIT_TERMINAL_PROMPT=0 to all git cmds Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
		
							parent
							
								
									131b59ef89
								
							
						
					
					
						commit
						a137ee7a68
					
				| 
						 | 
				
			
			@ -124,12 +124,18 @@ func (c *Command) RunInDirTimeoutEnvFullPipelineFunc(env []string, timeout time.
 | 
			
		|||
 | 
			
		||||
	cmd := exec.CommandContext(ctx, c.name, c.args...)
 | 
			
		||||
	if env == nil {
 | 
			
		||||
		cmd.Env = append(os.Environ(), fmt.Sprintf("LC_ALL=%s", DefaultLocale))
 | 
			
		||||
		cmd.Env = os.Environ()
 | 
			
		||||
	} else {
 | 
			
		||||
		cmd.Env = env
 | 
			
		||||
		cmd.Env = append(cmd.Env, fmt.Sprintf("LC_ALL=%s", DefaultLocale))
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	cmd.Env = append(
 | 
			
		||||
		cmd.Env,
 | 
			
		||||
		fmt.Sprintf("LC_ALL=%s", DefaultLocale),
 | 
			
		||||
		// avoid prompting for credentials interactively, supported since git v2.3
 | 
			
		||||
		"GIT_TERMINAL_PROMPT=0",
 | 
			
		||||
	)
 | 
			
		||||
 | 
			
		||||
	// TODO: verify if this is still needed in golang 1.15
 | 
			
		||||
	if goVersionLessThan115 {
 | 
			
		||||
		cmd.Env = append(cmd.Env, "GODEBUG=asyncpreemptoff=1")
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue