From f5dbac9d36f1678b928bee04e85fbd045c725698 Mon Sep 17 00:00:00 2001
From: Lunny Xiao <xiaolunwen@gmail.com>
Date: Tue, 8 Aug 2023 03:26:40 +0800
Subject: [PATCH] Use more `IssueList` instead of `[]*Issue` (#26369)

---
 models/issues/issue.go           | 6 +++---
 models/issues/issue_project.go   | 4 ++--
 models/issues/issue_search.go    | 2 +-
 routers/web/user/notification.go | 3 +--
 4 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/models/issues/issue.go b/models/issues/issue.go
index 38726de85..f000f4c66 100644
--- a/models/issues/issue.go
+++ b/models/issues/issue.go
@@ -854,8 +854,8 @@ func (issue *Issue) MovePin(ctx context.Context, newPosition int) error {
 }
 
 // GetPinnedIssues returns the pinned Issues for the given Repo and type
-func GetPinnedIssues(ctx context.Context, repoID int64, isPull bool) ([]*Issue, error) {
-	issues := make([]*Issue, 0)
+func GetPinnedIssues(ctx context.Context, repoID int64, isPull bool) (IssueList, error) {
+	issues := make(IssueList, 0)
 
 	err := db.GetEngine(ctx).
 		Table("issue").
@@ -868,7 +868,7 @@ func GetPinnedIssues(ctx context.Context, repoID int64, isPull bool) ([]*Issue,
 		return nil, err
 	}
 
-	err = IssueList(issues).LoadAttributes(ctx)
+	err = issues.LoadAttributes(ctx)
 	if err != nil {
 		return nil, err
 	}
diff --git a/models/issues/issue_project.go b/models/issues/issue_project.go
index 782638d99..ed249527b 100644
--- a/models/issues/issue_project.go
+++ b/models/issues/issue_project.go
@@ -53,7 +53,7 @@ func (issue *Issue) projectBoardID(ctx context.Context) int64 {
 
 // LoadIssuesFromBoard load issues assigned to this board
 func LoadIssuesFromBoard(ctx context.Context, b *project_model.Board) (IssueList, error) {
-	issueList := make([]*Issue, 0, 10)
+	issueList := make(IssueList, 0, 10)
 
 	if b.ID != 0 {
 		issues, err := Issues(ctx, &IssuesOptions{
@@ -79,7 +79,7 @@ func LoadIssuesFromBoard(ctx context.Context, b *project_model.Board) (IssueList
 		issueList = append(issueList, issues...)
 	}
 
-	if err := IssueList(issueList).LoadComments(ctx); err != nil {
+	if err := issueList.LoadComments(ctx); err != nil {
 		return nil, err
 	}
 
diff --git a/models/issues/issue_search.go b/models/issues/issue_search.go
index f9c1dbb38..281339044 100644
--- a/models/issues/issue_search.go
+++ b/models/issues/issue_search.go
@@ -441,7 +441,7 @@ func GetRepoIDsForIssuesOptions(opts *IssuesOptions, user *user_model.User) ([]i
 }
 
 // Issues returns a list of issues by given conditions.
-func Issues(ctx context.Context, opts *IssuesOptions) ([]*Issue, error) {
+func Issues(ctx context.Context, opts *IssuesOptions) (IssueList, error) {
 	sess := db.GetEngine(ctx).
 		Join("INNER", "repository", "`issue`.repo_id = `repository`.id")
 	applyLimit(sess, opts)
diff --git a/routers/web/user/notification.go b/routers/web/user/notification.go
index 60ae62844..579287ffa 100644
--- a/routers/web/user/notification.go
+++ b/routers/web/user/notification.go
@@ -296,8 +296,7 @@ func NotificationSubscriptions(ctx *context.Context) {
 	}
 	ctx.Data["CommitStatus"] = commitStatus
 
-	issueList := issues_model.IssueList(issues)
-	approvalCounts, err := issueList.GetApprovalCounts(ctx)
+	approvalCounts, err := issues.GetApprovalCounts(ctx)
 	if err != nil {
 		ctx.ServerError("ApprovalCounts", err)
 		return