core
/
gitea
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
gitea/routers/web
History
Zettat123 9a83aa28a3
Get rules by id when editing branch protection rule (#22932) 
When users rename an existing branch protection rule, a new rule with
the new name will be created and the old rule will still exist.

![image](https://user-images.githubusercontent.com/15528715/219276442-d3c001ad-e693-44ec-9ad2-b33f2666b49b.png)

---

![image](https://user-images.githubusercontent.com/15528715/219276478-547c3b93-b3f1-4292-a1ef-c1b7747fe1bb.png)

The reason is that the `SettingsProtectedBranchPost` function only get
branch protection rule by name before updating or creating a rule. When
the rule name changes, the function cannot find the existing rule so it
will create a new rule rather than update the existing rule. To fix the
bug, the function should get rule by id first.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 		2023-02-20 19:30:41 +08:00
..
admin Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
auth Provide the ability to set password hash algorithm parameters (#22942) 2023-02-19 15:35:20 +08:00
events Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
explore Remove ONLY_SHOW_RELEVANT_REPOS setting (#21962) 2023-02-04 21:26:38 +08:00
feed Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
healthcheck Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
misc Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
repo Get rules by id when editing branch protection rule (#22932) 2023-02-20 19:30:41 +08:00
shared Add Cargo package registry (#21888) 2023-02-05 18:12:31 +08:00
user Provide the ability to set password hash algorithm parameters (#22942) 2023-02-19 15:35:20 +08:00
auth.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
base.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
goget.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
home.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
metrics.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
swagger_json.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web.go Map OIDC groups to Orgs/Teams (#21441) 2023-02-08 14:44:42 +08:00
webfinger.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00