core
/
oga
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't modify raw namespaces. 

When calling Element#available_namespaces the list of namespaces returned by
Element#namespaces must not be modified.
This commit is contained in:
Yorick Peterse 2014-11-17 00:01:16 +01:00
parent a4459c866f
commit 804646cc5e
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/oga/xml/element.rb
View File

@ -273,7 +273,7 @@ module Oga
# @return [Hash] # @return [Hash]
# #
def available_namespaces def available_namespaces
merged = namespaces merged = namespaces.dup
node = parent node = parent
while node && node.respond_to?(:namespaces) while node && node.respond_to?(:namespaces)

4
spec/oga/xml/element_spec.rb
View File

@ -418,6 +418,10 @@ describe Oga::XML::Element do
example 'return the "baz" namespace for the parent' do example 'return the "baz" namespace for the parent' do
@parent_ns['baz'].uri.should == 'yyy' @parent_ns['baz'].uri.should == 'yyy'
end end
example 'do not modify the list of direct namespaces' do
@child.namespaces.key?('foo').should == false
end
end end
context '#self_closing?' do context '#self_closing?' do