core
/
oga
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Insert newlines after XML dec/doctypes.

This commit is contained in:
Yorick Peterse 2014-04-03 23:04:21 +02:00
parent 230fafa2d3
commit a2c525dd7c
2 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/oga/xml/document.rb
View File

@ -21,11 +21,11 @@ module Oga
xml = children.map(&:to_xml).join('')
if doctype
xml = doctype.to_xml + xml
xml = doctype.to_xml + "\n" + xml.strip
end
if xml_declaration
xml = xml_declaration.to_xml + xml
xml = xml_declaration.to_xml + "\n" + xml.strip
end
return xml

23
spec/oga/xml/document_spec.rb
View File

@ -43,7 +43,7 @@ describe Oga::XML::Document do
example 'include the XML of the declaration tag' do
@document.to_xml
.should == '<?xml version="5.0" encoding="UTF-8" ?><!--foo-->'
.should == %Q{<?xml version="5.0" encoding="UTF-8" ?>\n<!--foo-->}
end
end
@ -59,7 +59,26 @@ describe Oga::XML::Document do
end
example 'include the doctype' do
@document.to_xml.should == '<!DOCTYPE html PUBLIC><!--foo-->'
@document.to_xml.should == %Q{<!DOCTYPE html PUBLIC>\n<!--foo-->}
end
end
context '#to_xml with XML declarations and doctypes' do
before do
decl = Oga::XML::XmlDeclaration.new(:version => '5.0')
doctype = Oga::XML::Doctype.new(:name => 'html', :type => 'PUBLIC')
children = [Oga::XML::Comment.new(:text => 'foo')]
@document = described_class.new(
:doctype => doctype,
:xml_declaration => decl,
:children => children
)
end
example 'include the doctype and XML declaration' do
@document.to_xml.should == '<?xml version="5.0" encoding="UTF-8" ?>' \
"\n<!DOCTYPE html PUBLIC>\n<!--foo-->"
end
end
end