From ad4f650c5d1a883ef56ca37ef775d778a6ab4b00 Mon Sep 17 00:00:00 2001
From: Yorick Peterse <yorickpeterse@gmail.com>
Date: Mon, 17 Nov 2014 22:39:43 +0100
Subject: [PATCH] Fixed XML entity encoding/decoding ordering.

Thanks to @krasnoukhov for providing the initial patch, which this commit is
largely based on.

This fixes #49.
---
 lib/oga/xml/entities.rb       | 12 ++++++++----
 spec/oga/xml/entities_spec.rb | 24 ++++++++++++++++++++++++
 2 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/lib/oga/xml/entities.rb b/lib/oga/xml/entities.rb
index c054705..3fcef2b 100644
--- a/lib/oga/xml/entities.rb
+++ b/lib/oga/xml/entities.rb
@@ -4,15 +4,15 @@ module Oga
       ##
       # Hash containing XML entities and the corresponding characters.
       #
-      # The `&amp;` mapping must come first to ensure proper conversion of non
+      # The `&amp;` mapping must come last to ensure proper conversion of non
       # encoded to encoded forms (see {Oga::XML::Text#to_xml}).
       #
       # @return [Hash]
       #
       DECODE_MAPPING = {
-        '&amp;' => '&',
         '&lt;'  => '<',
-        '&gt;'  => '>'
+        '&gt;'  => '>',
+        '&amp;' => '&'
       }
 
       ##
@@ -20,7 +20,11 @@ module Oga
       #
       # @return [Hash]
       #
-      ENCODE_MAPPING = DECODE_MAPPING.invert
+      ENCODE_MAPPING = {
+        '&' => '&amp;',
+        '>' => '&gt;',
+        '<' => '&lt;'
+      }
 
       ##
       # Decodes XML entities.
diff --git a/spec/oga/xml/entities_spec.rb b/spec/oga/xml/entities_spec.rb
index 89e2de0..6a080ff 100644
--- a/spec/oga/xml/entities_spec.rb
+++ b/spec/oga/xml/entities_spec.rb
@@ -13,6 +13,22 @@ describe Oga::XML::Entities do
     example 'decode &gt; into >' do
       described_class.decode('&gt;').should == '>'
     end
+
+    example 'decode &amp;gt; into &gt;' do
+      described_class.decode('&amp;gt;').should == '&gt;'
+    end
+
+    example 'decode &amp;&amp;gt; into &>' do
+      described_class.decode('&amp;&amp;gt;').should == '&&gt;'
+    end
+
+    example 'decode &amp;lt; into <' do
+      described_class.decode('&amp;lt;').should == '&lt;'
+    end
+
+    example 'decode &amp;&amp;lt; into &<' do
+      described_class.decode('&amp;&amp;lt;').should == '&&lt;'
+    end
   end
 
   context 'encode' do
@@ -27,5 +43,13 @@ describe Oga::XML::Entities do
     example 'encode > as &gt;' do
       described_class.encode('>').should == '&gt;'
     end
+
+    example 'encode &gt; as &amp;gt;' do
+      described_class.encode('&gt;').should == '&amp;gt;'
+    end
+
+    example 'encode &lt; as &amp;lt;' do
+      described_class.encode('&lt;').should == '&amp;lt;'
+    end
   end
 end