Trimmed XML inspect values.

lib/oga/xml/attribute.rb

@@ -42,8 +42,17 @@ module Oga
       # @return [String]
       #
       def inspect
-        return "Attribute(name: #{name.inspect} " \
+        segments = []
-          "namespace: #{namespace.inspect} value: #{value.inspect})"
+
+        [:name, :namespace, :value].each do |attr|
+          value = send(attr)
+
+          if value and !value.empty?
+            segments << "#{attr}: #{value.inspect}"
+          end
+        end
+
+        return "Attribute(#{segments.join(' ')})"
       end
     end # Attribute
   end # XML

lib/oga/xml/doctype.rb

@@ -64,22 +64,20 @@ module Oga
       ##
       # Inspects the doctype.
       #
-      # @param [Fixnum] indent The indentation level for each line.
       # @return [String]
       #
-      def inspect(indent = 0)
+      def inspect
-        class_name = self.class.to_s.split('::').last
+        segments = []
-        spacing    = ' ' * indent
 
-        return <<-EOF.strip
+        [:name, :type, :public_id, :system_id, :inline_rules].each do |attr|
-#{class_name}(
+          value = send(attr)
-#{spacing}  name: #{name.inspect}
+
-#{spacing}  type: #{type.inspect}
+          if value and !value.empty?
-#{spacing}  public_id: #{public_id.inspect}
+            segments << "#{attr}: #{value.inspect}"
-#{spacing}  system_id: #{system_id.inspect}
+          end
-#{spacing}  inline_rules: #{inline_rules.inspect}
+        end
-#{spacing})
+
-        EOF
+        return "Doctype(#{segments.join(' ')})"
       end
 
       ##

lib/oga/xml/document.rb

@@ -115,29 +115,20 @@ module Oga
       # @return [String]
       #
       def inspect
-        class_name  = self.class.to_s.split('::').last
+        segments    = []
         child_lines = children.map { |child| child.inspect(4) }.join("\n")
 
-        if doctype
+        [:doctype, :xml_declaration].each do |attr|
-          dtd = doctype.inspect(2)
+          value = send(attr)
-        else
+
-          dtd = doctype.inspect
+          if value
+            segments << "#{attr}: #{value.inspect}"
+          end
         end
 
-        if xml_declaration
+        segments << "children: [\n#{child_lines}\n]"
-          decl = xml_declaration.inspect(2)
-        else
-          decl = xml_declaration.inspect
-        end
 
-        return <<-EOF.strip
+        return "Document(\n  #{segments.join("\n  ")})"
-#{class_name}(
-  doctype: #{dtd}
-  xml_declaration: #{decl}
-  children: [
-#{child_lines}
-])
-        EOF
       end
     end # Document
   end # XML

lib/oga/xml/element.rb

@@ -114,11 +114,19 @@ module Oga
         child_lines = children.map { |child| child.inspect(indent + 4) }
           .join("\n")
 
+        segments = []
+
+        [:name, :namespace, :attributes].each do |attr|
+          value = send(attr)
+
+          if value and !value.empty?
+            segments << "#{attr}: #{value.inspect}"
+          end
+        end
+
         return <<-EOF.chomp
 
-#{spacing}  name: #{name.inspect}
+#{spacing}  #{segments.join("\n#{spacing}  ")}
-#{spacing}  namespace: #{namespace.inspect}
-#{spacing}  attributes: #{attributes.inspect}
 #{spacing}  children: [
 #{child_lines}
 #{spacing}]

lib/oga/xml/xml_declaration.rb

@@ -49,20 +49,20 @@ module Oga
       end
 
       ##
-      # @param [Fixnum] indent
       # @return [String]
       #
-      def inspect(indent = 0)
+      def inspect
-        class_name = self.class.to_s.split('::').last
+        segments = []
-        spacing    = ' ' * indent
 
-        return <<-EOF.strip
+        [:version, :encoding, :standalone].each do |attr|
-#{class_name}(
+          value = send(attr)
-#{spacing}  version: #{version.inspect}
+
-#{spacing}  encoding: #{encoding.inspect}
+          if value and !value.empty?
-#{spacing}  standalone: #{standalone.inspect}
+            segments << "#{attr}: #{value.inspect}"
-#{spacing})
+          end
-        EOF
+        end
+
+        return "XmlDeclaration(#{segments.join(' ')})"
       end
 
       ##

spec/oga/xml/doctype_spec.rb

@@ -67,13 +67,7 @@ describe Oga::XML::Doctype do
 
     example 'pretty-print the node' do
       @instance.inspect.should == <<-EOF.strip
-Doctype(
+Doctype(name: "html" type: "PUBLIC" inline_rules: "<!ELEMENT foo>")
-  name: "html"
-  type: "PUBLIC"
-  public_id: nil
-  system_id: nil
-  inline_rules: "<!ELEMENT foo>"
-)
       EOF
     end
   end

spec/oga/xml/document_spec.rb

@@ -146,18 +146,8 @@ describe Oga::XML::Document do
     example 'pretty-print the node' do
       @instance.inspect.should == <<-EOF.strip
 Document(
-  doctype: Doctype(
+  doctype: Doctype(name: "html")
-    name: "html"
+  xml_declaration: XmlDeclaration(version: "1.0" encoding: "UTF-8")
-    type: nil
-    public_id: nil
-    system_id: nil
-    inline_rules: nil
-  )
-  xml_declaration: XmlDeclaration(
-    version: "1.0"
-    encoding: "UTF-8"
-    standalone: nil
-  )
   children: [
     Comment(text: "foo")
 ])
@@ -167,8 +157,6 @@ Document(
     example 'pretty-print a document without a doctype and XML declaration' do
       described_class.new.inspect.should == <<-EOF.strip
 Document(
-  doctype: nil
-  xml_declaration: nil
   children: [
 
 ])

spec/oga/xml/element_spec.rb

@@ -141,7 +141,6 @@ describe Oga::XML::Element do
       @instance.inspect.should == <<-EOF.strip
 Element(
   name: "p"
-  namespace: nil
   attributes: {"class"=>"foo"}
   children: [
     Comment(text: "foo")

spec/oga/xml/xml_declaration_spec.rb

@@ -50,11 +50,7 @@ describe Oga::XML::XmlDeclaration do
 
     example 'pretty-print the node' do
       @instance.inspect.should == <<-EOF.strip
-XmlDeclaration(
+XmlDeclaration(version: "1.0" encoding: "UTF-8")
-  version: "1.0"
-  encoding: "UTF-8"
-  standalone: nil
-)
       EOF
     end
   end