core
/
oga
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow XPath idents to start with an underscore. 

This is valid in XML so XPath should support it as well.
This commit is contained in:
Yorick Peterse 2014-11-05 00:35:47 +01:00
parent eb3a3e7630
commit f1316c50fb
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/oga/xpath/lexer.rl
View File

@ -194,7 +194,7 @@ module Oga
# Identifiers are used for element names, namespaces, attribute names, # Identifiers are used for element names, namespaces, attribute names,
# etc. Identifiers have to start with a letter. # etc. Identifiers have to start with a letter.
identifier = '*' | [a-zA-Z*]+ [a-zA-Z\-_0-9]*; identifier = '*' | [a-zA-Z*_]+ [a-zA-Z\-_0-9]*;
action emit_identifier { action emit_identifier {
emit(:T_IDENT, ts, te) emit(:T_IDENT, ts, te)

4
spec/oga/xpath/lexer/general_spec.rb
View File

@ -6,6 +6,10 @@ describe Oga::XPath::Lexer do
lex_xpath('/foo').should == [[:T_SLASH, nil], [:T_IDENT, 'foo']] lex_xpath('/foo').should == [[:T_SLASH, nil], [:T_IDENT, 'foo']]
end end
example 'lex a simple expression with a test starting with an underscore' do
lex_xpath('/_foo').should == [[:T_SLASH, nil], [:T_IDENT, '_foo']]
end
example 'lex a node test using a namespace' do example 'lex a node test using a namespace' do
lex_xpath('/foo:bar').should == [ lex_xpath('/foo:bar').should == [
[:T_SLASH, nil], [:T_SLASH, nil],