From 82584741ba107554e6e031067cb9d0392ad46ead Mon Sep 17 00:00:00 2001
From: Bohung <bohung@rulingcom.com>
Date: Mon, 3 Jan 2022 22:48:45 +0800
Subject: [PATCH] Fix link bug.

---
 app/models/writing_conference.rb                       | 8 ++++++--
 app/views/plugin/personal_conference/_profile.html.erb | 3 ++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/app/models/writing_conference.rb b/app/models/writing_conference.rb
index 60cd5d1..802efb9 100644
--- a/app/models/writing_conference.rb
+++ b/app/models/writing_conference.rb
@@ -125,7 +125,9 @@ class WritingConference
         if !page.nil? && page.custom_string_field == "table"
           case t
             when "paper_title"
-              pd_data << { "data_title" => "<a href='#{OrbitHelper.url_to_plugin_show(p.to_param,'personal_conference')}' title=\"#{p.paper_title}\" target='_blank'>#{p.paper_title}</a>" }
+              link = OrbitHelper.url_to_plugin_show(p.to_param,'personal_conference')
+              link = (link == "#" ? p.paper_title : "<a href='#{link}' title=\"#{p.paper_title}\" target='_blank'>#{p.paper_title}</a>")
+              pd_data << { "data_title" =>  link}
             when "paper_types"
               pd_data << {"data_title" => ( !p.conference_paper_types.blank? ? p.conference_paper_types.collect{|x| x.title}.join(', ') : "")}
             when "paper_levels"
@@ -141,7 +143,9 @@ class WritingConference
           end
         else
           if t == "paper_title"
-            pd_data << { "data_title" => "<a href='#{OrbitHelper.url_to_plugin_show(p.to_param,'personal_conference')}' title=\"#{p.create_link}\" target='_blank'>#{p.create_link}</a>" }
+            link = OrbitHelper.url_to_plugin_show(p.to_param,'personal_conference')
+            link = (link == "#" ? p.create_link : "<a href='#{link}' title=\"#{p.create_link}\" target='_blank'>#{p.create_link}</a>")
+            pd_data << { "data_title" => link }
           else
             pd_data << { "data_title" => p.send(t) }
           end
diff --git a/app/views/plugin/personal_conference/_profile.html.erb b/app/views/plugin/personal_conference/_profile.html.erb
index 93b9fba..dc88d50 100644
--- a/app/views/plugin/personal_conference/_profile.html.erb
+++ b/app/views/plugin/personal_conference/_profile.html.erb
@@ -45,7 +45,8 @@
         <% end %>
         <td><%= writing_conference.year %></td>
         <td>
-          <%= link_to writing_conference.paper_title, OrbitHelper.url_to_plugin_show(writing_conference.to_param,'personal_conference'), target: "blank"%>
+          <% link = OrbitHelper.url_to_plugin_show(writing_conference.to_param,'personal_conference') %>
+          <%= (link == "#" ? writing_conference.paper_title : link_to(writing_conference.paper_title, link , target: "blank")) %>
           <div class="quick-edit">
             <ul class="nav nav-pills hide">
               <% if has_access? %>