From 2c06c03f4daecaa367126e1f2220e236e23ad182 Mon Sep 17 00:00:00 2001
From: manson <manson@rulingcom.com>
Date: Wed, 10 Sep 2014 19:26:03 +0800
Subject: [PATCH] change member form first/last name position for zh_tw

---
 .../admin/members/_member_basic.html.erb      | 42 +++++--------------
 1 file changed, 11 insertions(+), 31 deletions(-)

diff --git a/app/views/admin/members/_member_basic.html.erb b/app/views/admin/members/_member_basic.html.erb
index df9d7fd..e50d4dc 100644
--- a/app/views/admin/members/_member_basic.html.erb
+++ b/app/views/admin/members/_member_basic.html.erb
@@ -35,50 +35,29 @@
         </div>
       </div>
 
-      <!-- First Name -->
-      <div class="control-group">
-          <label for="first_name" class="control-label muted" function="field_label"><%= t("users.first_name")%></label>
-        <div class="controls add-input">
-          <div class="add-target">
-            <div class="input-append">
-              <div class="tab-content">
-                <% @site_in_use_locales.each_with_index do |locale, i| %>
-                <div class="tab-pane fade <%= ( i == 0 ) ? "active in" : '' %>" id="first_name_<%= locale %>">
-                    <%= f.fields_for :first_name_translations do |f| %>
-                      <%= f.text_field locale, :value => (@member.first_name_translations[locale] rescue nil), :placeholder=>"#{t("users.first_name")}" %>
-                    <% end %>
-                </div>
-                <% end %>
-              </div>
-              <div class="btn-group" data-toggle="buttons-radio">
-                <% @site_in_use_locales.each_with_index do |locale, i| %>
-                  <a class="btn <%= ( i == 0 ) ? "active" : '' %>" href="#first_name_<%= locale %>" data-toggle="tab"><%= t(locale.to_s) %></a>
-                <% end %>
-                <a href="#" class="btn remove-input"><i class="icon-trash"></i></a>
-              </div>
-            </div>
-          </div>
-        </div>
-      </div>
+      <%
+        name_fields = ['first_name', 'last_name']
+        name_fields = ['last_name', 'first_name'] if I18n.locale.eql? :zh_tw 
+      %>
 
-      <!-- Last Name -->
+      <% name_fields.each do |name_field| %>
       <div class="control-group">
-          <label for="last_name" class="control-label muted" function="field_label"><%= t("users.last_name")%></label>
+          <label for="<%= name_field %>" class="control-label muted" function="field_label"><%= t("users.#{name_field}")%></label>
         <div class="controls add-input">
           <div class="add-target">
             <div class="input-append">
               <div class="tab-content">
                 <% @site_in_use_locales.each_with_index do |locale, i| %>
-                <div class="tab-pane fade <%= ( i == 0 ) ? "active in" : '' %>" id="last_name_<%= locale %>">
-                    <%= f.fields_for :last_name_translations do |f| %>
-                      <%= f.text_field locale, :value => (@member.last_name_translations[locale] rescue nil), :placeholder=>"#{t("users.last_name")}" %>
+                <div class="tab-pane fade <%= ( i == 0 ) ? "active in" : '' %>" id="<%= name_field %>_<%= locale %>">
+                    <%= f.fields_for "#{name_field}_translations".to_sym do |f| %>
+                      <%= f.text_field locale, :value => (@member.send("#{name_field}_translations")[locale] rescue nil), :placeholder=>"#{t("users.#{name_field}")}" %>
                     <% end %>
                 </div>
                 <% end %>
               </div>
               <div class="btn-group" data-toggle="buttons-radio">
                 <% @site_in_use_locales.each_with_index do |locale, i| %>
-                  <a class="btn <%= ( i == 0 ) ? "active" : '' %>" href="#last_name_<%= locale %>" data-toggle="tab"><%= t(locale).to_s %></a>
+                  <a class="btn <%= ( i == 0 ) ? "active" : '' %>" href="#<%= name_field %>_<%= locale %>" data-toggle="tab"><%= t(locale.to_s) %></a>
                 <% end %>
                 <a href="#" class="btn remove-input"><i class="icon-trash"></i></a>
               </div>
@@ -86,6 +65,7 @@
           </div>
         </div>
       </div>
+      <% end %>
 
       <!-- Email -->
       <div class="control-group">