Use retry_with_error in UserRefreshCredentials#revoke!

This commit is contained in:
Kazuhiro Serizawa 2017-02-25 21:59:45 +09:00
parent a1a9387c2b
commit 40f4e166a2
2 changed files with 28 additions and 9 deletions

View File

@ -92,6 +92,8 @@ module Google
# Revokes the credential # Revokes the credential
def revoke!(options = {}) def revoke!(options = {})
c = options[:connection] || Faraday.default_connection c = options[:connection] || Faraday.default_connection
retry_with_error do
resp = c.get(REVOKE_TOKEN_URI, token: refresh_token || access_token) resp = c.get(REVOKE_TOKEN_URI, token: refresh_token || access_token)
case resp.status case resp.status
when 200 when 200
@ -103,6 +105,7 @@ module Google
"Unexpected error code #{resp.status}") "Unexpected error code #{resp.status}")
end end
end end
end
# Verifies that a credential grants the requested scope # Verifies that a credential grants the requested scope
# #

View File

@ -293,4 +293,20 @@ describe Google::Auth::UserRefreshCredentials do
) )
end end
end end
describe 'when erros occured with request' do
it 'should fail with Signet::AuthorizationError if request times out' do
allow_any_instance_of(Faraday::Connection).to receive(:get)
.and_raise(Faraday::TimeoutError)
expect { @client.revoke! }
.to raise_error Signet::AuthorizationError
end
it 'should fail with Signet::AuthorizationError if request fails' do
allow_any_instance_of(Faraday::Connection).to receive(:get)
.and_raise(Faraday::ConnectionFailed, nil)
expect { @client.revoke! }
.to raise_error Signet::AuthorizationError
end
end
end end