Use retry_with_error in UserRefreshCredentials#revoke!

lib/googleauth/user_refresh.rb

@@ -92,15 +92,18 @@ module Google
       # Revokes the credential
       def revoke!(options = {})
         c = options[:connection] || Faraday.default_connection
-        resp = c.get(REVOKE_TOKEN_URI, token: refresh_token || access_token)
+
-        case resp.status
+        retry_with_error do
-        when 200
+          resp = c.get(REVOKE_TOKEN_URI, token: refresh_token || access_token)
-          self.access_token = nil
+          case resp.status
-          self.refresh_token = nil
+          when 200
-          self.expires_at = 0
+            self.access_token = nil
-        else
+            self.refresh_token = nil
-          raise(Signet::AuthorizationError,
+            self.expires_at = 0
-                "Unexpected error code #{resp.status}")
+          else
+            raise(Signet::AuthorizationError,
+                  "Unexpected error code #{resp.status}")
+          end
         end
       end
 

spec/googleauth/user_refresh_spec.rb

@@ -293,4 +293,20 @@ describe Google::Auth::UserRefreshCredentials do
       )
     end
   end
+
+  describe 'when erros occured with request' do
+    it 'should fail with Signet::AuthorizationError if request times out' do
+      allow_any_instance_of(Faraday::Connection).to receive(:get)
+        .and_raise(Faraday::TimeoutError)
+      expect { @client.revoke! }
+        .to raise_error Signet::AuthorizationError
+    end
+
+    it 'should fail with Signet::AuthorizationError if request fails' do
+      allow_any_instance_of(Faraday::Connection).to receive(:get)
+        .and_raise(Faraday::ConnectionFailed, nil)
+      expect { @client.revoke! }
+        .to raise_error Signet::AuthorizationError
+    end
+  end
 end