Use retry_with_error in UserRefreshCredentials#revoke!
This commit is contained in:
parent
a1a9387c2b
commit
40f4e166a2
|
@ -92,6 +92,8 @@ module Google
|
|||
# Revokes the credential
|
||||
def revoke!(options = {})
|
||||
c = options[:connection] || Faraday.default_connection
|
||||
|
||||
retry_with_error do
|
||||
resp = c.get(REVOKE_TOKEN_URI, token: refresh_token || access_token)
|
||||
case resp.status
|
||||
when 200
|
||||
|
@ -103,6 +105,7 @@ module Google
|
|||
"Unexpected error code #{resp.status}")
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
# Verifies that a credential grants the requested scope
|
||||
#
|
||||
|
|
|
@ -293,4 +293,20 @@ describe Google::Auth::UserRefreshCredentials do
|
|||
)
|
||||
end
|
||||
end
|
||||
|
||||
describe 'when erros occured with request' do
|
||||
it 'should fail with Signet::AuthorizationError if request times out' do
|
||||
allow_any_instance_of(Faraday::Connection).to receive(:get)
|
||||
.and_raise(Faraday::TimeoutError)
|
||||
expect { @client.revoke! }
|
||||
.to raise_error Signet::AuthorizationError
|
||||
end
|
||||
|
||||
it 'should fail with Signet::AuthorizationError if request fails' do
|
||||
allow_any_instance_of(Faraday::Connection).to receive(:get)
|
||||
.and_raise(Faraday::ConnectionFailed, nil)
|
||||
expect { @client.revoke! }
|
||||
.to raise_error Signet::AuthorizationError
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue