chiu
/
impressionist
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixed tests + added tests for conditionals

This commit is contained in:
Bashir Eghbali 2014-02-21 16:00:15 -08:00
parent 78a35925b2
commit 38ece35eb7
2 changed files with 132 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_app/config/initializers/impression.rb
View File

@ -5,4 +5,4 @@
#end #end
Impressionist.orm = :active_record

191
tests/test_app/spec/controllers/impressionist_uniqueness_spec.rb
View File

@ -10,63 +10,63 @@ describe DummyController do
describe "impressionist filter uniqueness" do describe "impressionist filter uniqueness" do
it "should ignore uniqueness if not requested" do it "should ignore uniqueness if not requested" do
controller.impressionist_subapp_filter(nil, nil) controller.impressionist_subapp_filter
controller.impressionist_subapp_filter(nil, nil) controller.impressionist_subapp_filter
Impression.should have(@impression_count + 2).records Impression.should have(@impression_count + 2).records
end end
it "should recognize unique session" do it "should recognize unique session" do
controller.stub(:session_hash).and_return(request.session_options[:id]) controller.stub(:session_hash).and_return(request.session_options[:id])
controller.impressionist_subapp_filter(nil, [:session_hash]) controller.impressionist_subapp_filter(unique: [:session_hash])
controller.impressionist_subapp_filter(nil, [:session_hash]) controller.impressionist_subapp_filter(unique: [:session_hash])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
it "should recognize unique ip" do it "should recognize unique ip" do
controller.request.stub(:remote_ip).and_return("1.2.3.4") controller.request.stub(:remote_ip).and_return("1.2.3.4")
controller.impressionist_subapp_filter(nil, [:ip_address]) controller.impressionist_subapp_filter(unique: [:ip_address])
controller.impressionist_subapp_filter(nil, [:ip_address]) controller.impressionist_subapp_filter(unique: [:ip_address])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
it "should recognize unique request" do it "should recognize unique request" do
controller.impressionist_subapp_filter(nil, [:request_hash]) controller.impressionist_subapp_filter(unique: [:request_hash])
controller.impressionist_subapp_filter(nil, [:request_hash]) controller.impressionist_subapp_filter(unique: [:request_hash])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
it "should recognize unique action" do it "should recognize unique action" do
controller.stub(:action_name).and_return("test_action") controller.stub(:action_name).and_return("test_action")
controller.impressionist_subapp_filter(nil, [:action_name]) controller.impressionist_subapp_filter(unique: [:action_name])
controller.impressionist_subapp_filter(nil, [:action_name]) controller.impressionist_subapp_filter(unique: [:action_name])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
it "should recognize unique controller" do it "should recognize unique controller" do
controller.stub(:controller_name).and_return("post") controller.stub(:controller_name).and_return("post")
controller.impressionist_subapp_filter(nil, [:controller_name]) controller.impressionist_subapp_filter(unique: [:controller_name])
controller.impressionist_subapp_filter(nil, [:controller_name]) controller.impressionist_subapp_filter(unique: [:controller_name])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
it "should recognize unique user" do it "should recognize unique user" do
controller.stub(:user_id).and_return(42) controller.stub(:user_id).and_return(42)
controller.impressionist_subapp_filter(nil, [:user_id]) controller.impressionist_subapp_filter(unique: [:user_id])
controller.impressionist_subapp_filter(nil, [:user_id]) controller.impressionist_subapp_filter(unique: [:user_id])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
it "should recognize unique referer" do it "should recognize unique referer" do
controller.request.stub(:referer).and_return("http://foo/bar") controller.request.stub(:referer).and_return("http://foo/bar")
controller.impressionist_subapp_filter(nil, [:referrer]) controller.impressionist_subapp_filter(unique: [:referrer])
controller.impressionist_subapp_filter(nil, [:referrer]) controller.impressionist_subapp_filter(unique: [:referrer])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
it "should recognize unique id" do it "should recognize unique id" do
controller.stub(:params).and_return({:id => "666"}) # for correct impressionable id in filter controller.stub(:params).and_return({:id => "666"}) # for correct impressionable id in filter
controller.impressionist_subapp_filter(nil, [:impressionable_id]) controller.impressionist_subapp_filter(unique: [:impressionable_id])
controller.impressionist_subapp_filter(nil, [:impressionable_id]) controller.impressionist_subapp_filter(unique: [:impressionable_id])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
@ -74,104 +74,104 @@ describe DummyController do
it "should recognize different controller and action" do it "should recognize different controller and action" do
controller.stub(:controller_name).and_return("post") controller.stub(:controller_name).and_return("post")
controller.stub(:action_name).and_return("test_action") controller.stub(:action_name).and_return("test_action")
controller.impressionist_subapp_filter(nil, [:controller_name, :action_name]) controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
controller.impressionist_subapp_filter(nil, [:controller_name, :action_name]) controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
controller.stub(:action_name).and_return("another_action") controller.stub(:action_name).and_return("another_action")
controller.impressionist_subapp_filter(nil, [:controller_name, :action_name]) controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
controller.impressionist_subapp_filter(nil, [:controller_name, :action_name]) controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
Impression.should have(@impression_count + 2).records Impression.should have(@impression_count + 2).records
controller.stub(:controller_name).and_return("article") controller.stub(:controller_name).and_return("article")
controller.impressionist_subapp_filter(nil, [:controller_name, :action_name]) controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
controller.impressionist_subapp_filter(nil, [:controller_name, :action_name]) controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
Impression.should have(@impression_count + 3).records Impression.should have(@impression_count + 3).records
end end
it "should recognize different action" do it "should recognize different action" do
controller.stub(:action_name).and_return("test_action") controller.stub(:action_name).and_return("test_action")
controller.impressionist_subapp_filter(nil, [:action_name]) controller.impressionist_subapp_filter(unique: [:action_name])
controller.impressionist_subapp_filter(nil, [:action_name]) controller.impressionist_subapp_filter(unique: [:action_name])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
controller.stub(:action_name).and_return("another_action") controller.stub(:action_name).and_return("another_action")
controller.impressionist_subapp_filter(nil, [:action_name]) controller.impressionist_subapp_filter(unique: [:action_name])
controller.impressionist_subapp_filter(nil, [:action_name]) controller.impressionist_subapp_filter(unique: [:action_name])
Impression.should have(@impression_count + 2).records Impression.should have(@impression_count + 2).records
end end
it "should recognize different controller" do it "should recognize different controller" do
controller.stub(:controller_name).and_return("post") controller.stub(:controller_name).and_return("post")
controller.impressionist_subapp_filter(nil, [:controller_name]) controller.impressionist_subapp_filter(unique: [:controller_name])
controller.impressionist_subapp_filter(nil, [:controller_name]) controller.impressionist_subapp_filter(unique: [:controller_name])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
controller.stub(:controller_name).and_return("article") controller.stub(:controller_name).and_return("article")
controller.impressionist_subapp_filter(nil, [:controller_name]) controller.impressionist_subapp_filter(unique: [:controller_name])
controller.impressionist_subapp_filter(nil, [:controller_name]) controller.impressionist_subapp_filter(unique: [:controller_name])
Impression.should have(@impression_count + 2).records Impression.should have(@impression_count + 2).records
end end
it "should recognize different session" do it "should recognize different session" do
controller.stub(:session_hash).and_return("foo") controller.stub(:session_hash).and_return("foo")
controller.impressionist_subapp_filter(nil, [:session_hash]) controller.impressionist_subapp_filter(unique: [:session_hash])
controller.impressionist_subapp_filter(nil, [:session_hash]) controller.impressionist_subapp_filter(unique: [:session_hash])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
controller.stub(:session_hash).and_return("bar") controller.stub(:session_hash).and_return("bar")
controller.impressionist_subapp_filter(nil, [:session_hash]) controller.impressionist_subapp_filter(unique: [:session_hash])
controller.impressionist_subapp_filter(nil, [:session_hash]) controller.impressionist_subapp_filter(unique: [:session_hash])
Impression.should have(@impression_count + 2).records Impression.should have(@impression_count + 2).records
end end
it "should recognize different ip" do it "should recognize different ip" do
controller.request.stub(:remote_ip).and_return("1.2.3.4") controller.request.stub(:remote_ip).and_return("1.2.3.4")
controller.impressionist_subapp_filter(nil, [:ip_address]) controller.impressionist_subapp_filter(unique: [:ip_address])
controller.impressionist_subapp_filter(nil, [:ip_address]) controller.impressionist_subapp_filter(unique: [:ip_address])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
controller.request.stub(:remote_ip).and_return("5.6.7.8") controller.request.stub(:remote_ip).and_return("5.6.7.8")
controller.impressionist_subapp_filter(nil, [:ip_address]) controller.impressionist_subapp_filter(unique: [:ip_address])
controller.impressionist_subapp_filter(nil, [:ip_address]) controller.impressionist_subapp_filter(unique: [:ip_address])
Impression.should have(@impression_count + 2).records Impression.should have(@impression_count + 2).records
end end
it "should recognize different referer" do it "should recognize different referer" do
controller.request.stub(:referer).and_return("http://foo/bar") controller.request.stub(:referer).and_return("http://foo/bar")
controller.impressionist_subapp_filter(nil, [:referrer]) controller.impressionist_subapp_filter(unique: [:referrer])
controller.impressionist_subapp_filter(nil, [:referrer]) controller.impressionist_subapp_filter(unique: [:referrer])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
controller.request.stub(:referer).and_return("http://bar/fo") controller.request.stub(:referer).and_return("http://bar/fo")
controller.impressionist_subapp_filter(nil, [:referrer]) controller.impressionist_subapp_filter(unique: [:referrer])
controller.impressionist_subapp_filter(nil, [:referrer]) controller.impressionist_subapp_filter(unique: [:referrer])
Impression.should have(@impression_count + 2).records Impression.should have(@impression_count + 2).records
end end
it "should recognize different id" do it "should recognize different id" do
controller.stub(:params).and_return({:id => "666"}) # for correct impressionable id in filter controller.stub(:params).and_return({:id => "666"}) # for correct impressionable id in filter
controller.impressionist_subapp_filter(nil, [:impressionable_type, :impressionable_id]) controller.impressionist_subapp_filter(unique: [:impressionable_type, :impressionable_id])
controller.impressionist_subapp_filter(nil, [:impressionable_type, :impressionable_id]) controller.impressionist_subapp_filter(unique: [:impressionable_type, :impressionable_id])
controller.stub(:params).and_return({:id => "42"}) # for correct impressionable id in filter controller.stub(:params).and_return({:id => "42"}) # for correct impressionable id in filter
controller.impressionist_subapp_filter(nil, [:impressionable_type, :impressionable_id]) controller.impressionist_subapp_filter(unique: [:impressionable_type, :impressionable_id])
controller.impressionist_subapp_filter(nil, [:impressionable_type, :impressionable_id]) controller.impressionist_subapp_filter(unique: [:impressionable_type, :impressionable_id])
Impression.should have(@impression_count + 2).records Impression.should have(@impression_count + 2).records
end end
it "should recognize combined uniqueness" do it "should recognize combined uniqueness" do
controller.stub(:action_name).and_return("test_action") controller.stub(:action_name).and_return("test_action")
controller.impressionist_subapp_filter(nil, [:ip_address, :request_hash, :action_name]) controller.impressionist_subapp_filter(unique: [:ip_address, :request_hash, :action_name])
controller.impressionist_subapp_filter(nil, [:request_hash, :ip_address, :action_name]) controller.impressionist_subapp_filter(unique: [:request_hash, :ip_address, :action_name])
controller.impressionist_subapp_filter(nil, [:request_hash, :action_name]) controller.impressionist_subapp_filter(unique: [:request_hash, :action_name])
controller.impressionist_subapp_filter(nil, [:ip_address, :action_name]) controller.impressionist_subapp_filter(unique: [:ip_address, :action_name])
controller.impressionist_subapp_filter(nil, [:ip_address, :request_hash]) controller.impressionist_subapp_filter(unique: [:ip_address, :request_hash])
controller.impressionist_subapp_filter(nil, [:action_name]) controller.impressionist_subapp_filter(unique: [:action_name])
controller.impressionist_subapp_filter(nil, [:ip_address]) controller.impressionist_subapp_filter(unique: [:ip_address])
controller.impressionist_subapp_filter(nil, [:request_hash]) controller.impressionist_subapp_filter(unique: [:request_hash])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
it "should recognize combined non-uniqueness" do it "should recognize combined non-uniqueness" do
controller.stub(:action_name).and_return(nil) controller.stub(:action_name).and_return(nil)
controller.impressionist_subapp_filter(nil, [:ip_address, :action_name]) controller.impressionist_subapp_filter(unique: [:ip_address, :action_name])
controller.stub(:action_name).and_return("test_action") controller.stub(:action_name).and_return("test_action")
controller.impressionist_subapp_filter(nil, [:ip_address, :action_name]) controller.impressionist_subapp_filter(unique: [:ip_address, :action_name])
controller.stub(:action_name).and_return("another_action") controller.stub(:action_name).and_return("another_action")
controller.impressionist_subapp_filter(nil, [:ip_address, :action_name]) controller.impressionist_subapp_filter(unique: [:ip_address, :action_name])
Impression.should have(@impression_count + 3).records Impression.should have(@impression_count + 3).records
end end
@ -299,12 +299,83 @@ describe DummyController do
controller.stub(:session_hash).and_return("foo") controller.stub(:session_hash).and_return("foo")
controller.request.stub(:remote_ip).and_return("1.2.3.4") controller.request.stub(:remote_ip).and_return("1.2.3.4")
# order of the following methods is important for the test! # order of the following methods is important for the test!
controller.impressionist_subapp_filter(nil, [:ip_address, :request_hash, :session_hash]) controller.impressionist_subapp_filter(unique: [:ip_address, :request_hash, :session_hash])
controller.impressionist(impressionable, nil, :unique => [:ip_address, :request_hash, :session_hash]) controller.impressionist(impressionable, nil, :unique => [:ip_address, :request_hash, :session_hash])
Impression.should have(@impression_count + 1).records Impression.should have(@impression_count + 1).records
end end
end end
shared_examples_for 'an impressionable action' do
it 'should record an impression' do
controller.impressionist_subapp_filter(condition)
Impression.should have(@impression_count + 1).records
end
end
shared_examples_for 'an unimpressionable action' do
it 'should record an impression' do
controller.impressionist_subapp_filter(condition)
Impression.should have(@impression_count).records
end
end
describe "conditional impressions" do
describe ":if condition" do
context "true condition" do
before do
controller.stub(:true_condition).and_return(true)
end
it_behaves_like 'an impressionable action' do
let(:condition) {{ if: :true_condition }}
end
it_behaves_like 'an impressionable action' do
let(:condition) {{ if: lambda { true_condition } }}
end
end
context "false condition" do
before do
controller.stub(:false_condition).and_return(false)
end
it_behaves_like 'an unimpressionable action' do
let(:condition) {{ if: :false_condition }}
end
it_behaves_like 'an unimpressionable action' do
let(:condition) {{ if: lambda { false_condition } }}
end
end
end
describe ":unless condition" do
context "true condition" do
before do
controller.stub(:true_condition).and_return(true)
end
it_behaves_like 'an unimpressionable action' do
let(:condition) {{ unless: :true_condition }}
end
it_behaves_like 'an unimpressionable action' do
let(:condition) {{ unless: lambda { true_condition } }}
end
end
context "false condition" do
before do
controller.stub(:false_condition).and_return(false)
end
it_behaves_like 'an impressionable action' do
let(:condition) {{ if: :false_condition }}
end
it_behaves_like 'an impressionable action' do
let(:condition) {{ if: lambda { false_condition } }}
end
end
end
end
end end