Commit Graph

27 Commits

Author SHA1 Message Date
Matt 6bc9eb8e69
Make session hash work with more versions of Rack/Rails (#298)
* fix id null and bump version
* update session_hash to work with more versions of rack and rails.

Co-authored-by: Reza J. Bavaghoush <rzjfr@yahoo.com>
Co-authored-by: Russell Osborne <russell.osborne@framebridge.com>
Co-authored-by: Sing, Tran Lu Sinh <tran.lu.sinh@moneyforward.vn>
2021-12-20 20:11:44 -05:00
Matt ef7bec89dc
Fix CI builds (#286)
* update test app gems and fix more deprecation errors
* replace minitest with rspec for consistency. cleanup Rakefile
2020-07-20 09:35:41 -04:00
John McAliley 00d3a457c7
Merge pull request #283 from Plaristote/master
remove deprecated use of ActionDispatch::Http::ParameterFilter
2020-04-18 02:28:24 -04:00
Michael 4dc9010fbc replace ActionDispatch::Http::ParameterFilter with ActiveSupport::ParameterFilter 2020-04-05 17:45:39 +02:00
xiaohui c5d4fce6e1
compact with rack 2.0.8+ 2019-12-20 11:14:20 +08:00
Russell Osborne b59f640b19 Use action dispatch filter to support nested filters and other rails 5 features. 2017-05-26 12:18:47 -04:00
Russell Osborne d1058a030e Remove filtered params from being stored in db 2017-05-26 12:18:47 -04:00
M. Simon Borg 5ed366de82 use before_action for rails 5, maintain backwards compat. 2017-05-10 15:20:11 -04:00
asharma-ror 2e72b5aefa params feature 2015-04-21 15:51:47 +05:30
Md. Tauhidul Islam f77d187f66 Unique impressionist count for objects which are using friendly_id 2015-02-07 22:08:32 +06:00
Bashir Eghbali 78a35925b2 cleaned up the logic. too much double negative 2014-02-21 15:32:07 -08:00
Bashir Eghbali 2e5dabe9b3 added :if and :unless conditionals to impressionist 2014-02-21 13:13:33 -08:00
Peter M. Goldstein 68ea36a7fe Make associative_create_statement protected rather than private, so it can be accessed by subclasses. This makes it easy for subclasses to add custom fields to the impression. 2013-09-22 11:43:59 -07:00
John McAliley ce935aaa38 change controller_path back to controller_name
This is causing missing constant errors for people who are upgrading
2013-05-07 21:40:59 -03:00
ChaYoung You df8489163e Change generating impressionable_type by from controller_name to controller_path 2013-04-01 04:19:24 +09:00
Ross Kaffenberger 3a64d4b9ab Add extract controller logic for bypassing impression to bot? method 2012-03-20 17:04:00 -04:00
Erik Michaels-Ober 1174647779 Cleanup trailing whitespace
Trailing whitespace isn't friendly to git or vim users.
2012-03-06 14:04:32 -08:00
Kai Schlichting e5566fad8a speedup unique impressions by using "Impression#exists?" instead of "#Impression#size == 0" 2012-01-19 21:29:23 +01:00
mio 132f1f74ec fixed typo 2011-11-10 14:14:51 +01:00
mio e63e835936 added draft for impressionist(...) uniqueness 2011-11-09 18:10:35 +01:00
mio 09bfa2f27e implemented first version for unique check on controller level. 2011-11-07 20:41:51 +01:00
John McAliley ae5ae23e1c Add referrer to impression model.
remove unused features dir.
2011-06-03 11:52:42 -04:00
cowboycoded 405d376366 add session_hash to impression model
changed migration template
added upgrade migration template
added unique_impression_count_session to impressionable model
fixed controller_spec
2011-03-06 23:22:39 -05:00
cowboycoded 7c1ac8ccdc log the controller_name and action_name when impressionist is called manually inside a controller action 2011-02-17 08:11:06 -05:00
cowboycoded aeb42cc165 change back to module. causing problems in dev with reopen implementation 2011-02-13 14:15:31 -05:00
cowboycoded ec1b40487d simply reopen ApplicationController instead of using include/extend. As long as the file is not named "application_controller.rb", then it will load. Rails does not load files from engine /app that have the same name as files in container application /app dir 2011-02-04 10:13:27 -05:00
cowboycoded 755bd937da first commit 2011-02-03 23:13:41 -05:00