Replace `:compression` option with `:reset_accept_encoding`

The default is to now to not clear the `Accept-Encoding` header (this can be changed back to the older behavior by passing `reset_accept_encoding: true`)
This commit is contained in:
Kyle Lacy 2018-04-18 21:24:31 -07:00
parent 5662cc2bde
commit 46eaa864b3
2 changed files with 10 additions and 21 deletions

View File

@ -65,14 +65,6 @@ If you'd like to bypass SSL verification
reverse_proxy "http://localhost:8000", verify_ssl: false reverse_proxy "http://localhost:8000", verify_ssl: false
``` ```
If you'd like to allow the proxy to request compressed resources by forwarding the `Accept-Encoding` header
```ruby
reverse_proxy "http://localhost:8000", compression: :passthrough
# Note that your controller's response will only be compressed
# if the original response from localhost:8000 is compressed!
```
If you'd like to customize the options passed into the [HTTP session](https://ruby-doc.org/stdlib-2.4.0/libdoc/net/http/rdoc/Net/HTTP.html#start-method) If you'd like to customize the options passed into the [HTTP session](https://ruby-doc.org/stdlib-2.4.0/libdoc/net/http/rdoc/Net/HTTP.html#start-method)
```ruby ```ruby

View File

@ -44,7 +44,7 @@ module ReverseProxy
username: nil, username: nil,
password: nil, password: nil,
verify_ssl: true, verify_ssl: true,
compression: :disabled reset_accept_encoding: false
) )
source_request = Rack::Request.new(env) source_request = Rack::Request.new(env)
@ -74,12 +74,9 @@ module ReverseProxy
# Hold the response here # Hold the response here
target_response = nil target_response = nil
case options[:compression] if options[:reset_accept_encoding]
when :passthrough # Clear the "Accept-Encoding" header (which will
# Pass along the "Accept-Encoding" header from the source request as-is, # disable compression or other server-side encodings)
# so we don't need to change anything
when :disabled, false, nil
# Remove the "Accept-Encoding" header if compression is disabled
target_request['Accept-Encoding'] = nil target_request['Accept-Encoding'] = nil
end end