86ee5b4b1b
Fixes: #26333.
Previously, this endpoint only updates the `StatusCheckContexts` field
when `EnableStatusCheck==true`, which makes it impossible to clear the
array otherwise.
This patch uses slice `nil`-ness to decide whether to update the list of
checks. The field is ignored when either the client explicitly passes in
a null, or just omits the field from the json ([which causes
`json.Unmarshal` to leave the struct field
unchanged](https://go.dev/play/p/Z2XHOILuB1Q)). I think this is a better
measure of intent than whether the `EnableStatusCheck` flag was set,
because it matches the semantics of other field types.
Also adds a test case. I noticed that [`testAPIEditBranchProtection`
only checks the branch
name](
|
||
|---|---|---|
| .. | ||
| activitypub | ||
| admin | ||
| misc | ||
| notify | ||
| org | ||
| packages | ||
| repo | ||
| settings | ||
| swagger | ||
| user | ||
| utils | ||
| api.go | ||
| auth.go | ||
| auth_windows.go | ||