gitea/templates/repo
sillyguodong bfecf3bd89
Fix internal sever error when visiting a PR that bound to the deleted team (#24127)
Close: #23738

The actual cause of `500 Internal Server Error` in the issue is not what
is descirbed in the issue.

The actual cause is that after deleting team, if there is a PR which has
requested reivew from the deleted team, the comment could not match with
the deleted team by `assgin_team_id`. So the value of `.AssigneeTeam`
(see below code block) is `nil` which cause `500 error`.


1c8bc4081a/templates/repo/issue/view_content/comments.tmpl (L691-L695)

To fix this bug, there are the following problems to be resolved:

- [x] 1. ~~Stroe the name of the team in `content` column when inserting
`comment` into DB in case that we cannot get the name of team after it
is deleted. But for comments that already exist, just display "Unknown
Team"~~ Just display "Ghost Team" in the comment if the assgined team is
deleted.
- [x] 2. Delete the PR&team binding (the row of which `review_team_id =
${team_id} ` in table `review`) when deleting team.
- [x] 3.For already exist and undeleted binding rows in in table
`review`, ~~we can delete these rows when executing migrations.~~ they
do not affect the function, so won't delete them.
2023-04-19 19:50:00 -04:00
..
actions
branch
cite
diff
editor
find
graph Use a general Eval function for expressions in templates. (#23927) 2023-04-07 21:25:49 +08:00
issue
migrate Group template helper functions, remove `Printf`, improve template error messages (#23982) 2023-04-08 21:15:22 +08:00
projects
pulls Discolor pull request tab labels (#23950) 2023-04-07 15:12:45 -04:00
release
settings Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
wiki Make wiki title supports dashes and improve wiki name related features (#24143) 2023-04-19 13:50:10 -04:00
activity.tmpl
blame.tmpl
branch_dropdown.tmpl
clone_buttons.tmpl
clone_script.tmpl
commit_page.tmpl
commit_status.tmpl
commit_statuses.tmpl
commits.tmpl
commits_list.tmpl
commits_list_small.tmpl
commits_table.tmpl
create.tmpl
create_helper.tmpl
empty.tmpl
file_info.tmpl
forks.tmpl
graph.tmpl
header.tmpl
home.tmpl
icon.tmpl
packages.tmpl
search.tmpl
search_name.tmpl
shabox_badge.tmpl
sub_menu.tmpl
unicode_escape_prompt.tmpl
upload.tmpl
user_cards.tmpl
view_file.tmpl
view_list.tmpl
watchers.tmpl