e5c1d3ebf1
Merge branch 'patch-1' of github.com:msimonborg/impressionist into patch-1
2017-05-10 15:20:35 -04:00
5ed366de82
use before_action for rails 5, maintain backwards compat.
2017-05-10 15:20:11 -04:00
6cd542df7a
use before_action only for Rails >= 5
...
conditional branch on `Rails::VERSION::MAJOR` for backwards compatibility
2017-05-10 14:59:11 -04:00
51c054e200
before_filter -> before_action
...
`before_filter` is deprecated in favor of `before_action` and removed in Rails 5.1
2017-05-10 09:52:26 -04:00
6f22014650
splat args in SetupAssociation test
2017-05-10 08:49:15 -04:00
800c24ec64
Merge pull request #238 from charlotte-ruby/green-builds
...
Green builds
2017-04-28 08:20:39 +02:00
efc7a54d09
Merge pull request #239 from econya/doc-COUNTER_CACHE_VIA_RAILSGMIGRATION
...
Readme: add `rails g migration` example for counter_cache for model
2017-04-28 08:12:10 +02:00
987cb57aab
Specify the build command
...
Travis defaults to just running `rake` but on newer ruby versions on
Travis, rake v. 12 is already installed which results in
```
Gem::LoadError: You have already activated rake 12.0.0, but your Gemfile requires rake 10.5.0. Prepending `bundle exec` to your command may solve this.
```
2017-04-28 08:00:36 +02:00
061eccf422
Add new ruby versions to travis test matrix
2017-04-28 08:00:35 +02:00
6fd0cfcb64
Update the bundler version on Travis CI
2017-04-28 08:00:34 +02:00
595aa46de5
Lock public_suffix to pre 1.5.0
...
The 1.5.0 version of public_suffix drops support
for ruby version < 2.0 which we still support.
2017-04-28 08:00:34 +02:00
89458144be
Lock rake to a version pre 11.0
...
Rake version 11.0 removed the `last_comment`
method which is used by `rspec 2.14.x` which we
use in this test app.
2017-04-28 08:00:33 +02:00
4c64d521a3
Lock nokogiri to 1.6.x
...
From nokogiri 1.7.0 ruby <= 2.0.0 are no longer
supported. In order to support those version
we must lock ourselves to 1.6.x
2017-04-28 08:00:33 +02:00
ef3f9eab24
provide one-liner for counter_cache migration via rails g m
2017-04-18 15:57:48 +02:00
f38d4cdb73
Merge pull request #228 from abartov/patch-1
...
Fix blob length in create_index in the generated migration
2017-03-10 12:42:34 -05:00
62299d195f
Merge pull request #223 from dancinglightning/master
...
small doc fix for readme step 4
2017-03-10 12:35:33 -05:00
1af8d57802
Fix blob length in create_index in the generated migration
2017-01-08 18:21:38 -08:00
6f2783a945
small doc fix for readme step 4
2016-12-03 18:48:36 +02:00
b96921d24c
bump version to 1.5.2
2016-09-16 09:37:36 -04:00
03379bf003
Merge pull request #213 from yarikov/master
...
Rails 5: wrong number of arguments (given 2, expected 0..1)
2016-09-16 09:22:11 -04:00
a0fddc9072
Fix: wrong number of arguments (given 2, expected 0..1)
2016-07-08 11:42:33 +03:00
6e551927ec
Merge pull request #208 from spodlecki/removing-httpclient
...
Remove httpclient due to deprecation warning for #timeout
2016-02-02 19:28:34 -05:00
14794f8e34
travis updates and gemfile test for travis
2015-12-30 16:54:57 -06:00
b38845ac6f
removing httpclient due to deprecation warning
2015-12-30 16:40:05 -06:00
aae429286d
Merge pull request #202 from tansengming/feature/updates-nokogiri
...
updates nokogiri
2015-12-03 09:23:03 -05:00
abe390113f
updates nokogiri
2015-11-04 13:16:59 +11:00
729e4fca3b
Merge pull request #188 from asharma-ror/params_feature
...
Params feature
2015-06-24 22:18:11 -04:00
ae01d1ccb8
Merge pull request #189 from JisuPark/patch-1
...
Typing error corrected
2015-06-24 22:16:08 -04:00
81a9c5f022
Typos corrected
...
impressionalble => impressionable
2015-04-23 15:33:49 +09:00
04d80ef172
Fixed the failing case.
2015-04-22 11:08:10 +05:30
8c3407fd33
Adding params field to migration file.
2015-04-22 10:43:47 +05:30
9d997bc600
readme for params feature
2015-04-21 15:55:37 +05:30
2e72b5aefa
params feature
2015-04-21 15:51:47 +05:30
432b77e40d
Merge pull request #182 from tauhidul35/master
...
Unique impressionist of a instance which is using friendly_id
2015-02-09 20:21:13 -05:00
66c7533f47
- Fix test code for unique impressionist of instance with friendly_id
...
- Fixed rspec-rails version for run previous test cases
- Add friendly_id in gemfiles for run test case
2015-02-08 02:03:34 +06:00
5573aebeaa
Change friendly_id gem version
2015-02-08 00:54:41 +06:00
8573b40e6f
Add friendly_id to test group in gem file
2015-02-08 00:43:38 +06:00
f77d187f66
Unique impressionist count for objects which are using friendly_id
2015-02-07 22:08:32 +06:00
cacdd66fd8
Merge pull request #154 from zonkeynir/master
...
Issue for mongoid
2014-04-30 15:51:25 -04:00
af3466a0c3
Merge pull request #151 from kinopyo/patch-2
...
Update README.md for #impressionist method
2014-04-30 15:49:52 -04:00
aa27664381
Merge pull request #150 from kinopyo/patch-1
...
Update README.md for usage with friendly_id
2014-04-30 15:48:17 -04:00
c69437bfff
Issue for mongoid
...
Queries is always on ObjectId type of imperssion_id, while model not restricts the type.
Thats can cause to saves in String format, hence not imperssions will be counted on counter_cache
2014-04-28 17:50:14 +03:00
d93dd0e356
Update README.md for #impressionist method
...
A quick fix for https://github.com/charlotte-ruby/impressionist/issues/138
2014-04-17 17:12:48 +09:00
2bb18c0d95
Update README.md for usage with friendly_id
2014-04-17 17:03:48 +09:00
cb0002a7d2
Merge pull request #144 from beghbali/master
...
added :if and :unless conditionals to impressionist
2014-03-25 22:01:00 -04:00
d157b1feff
fixed specs
2014-02-21 16:09:57 -08:00
38ece35eb7
fixed tests + added tests for conditionals
2014-02-21 16:00:15 -08:00
78a35925b2
cleaned up the logic. too much double negative
2014-02-21 15:32:07 -08:00
2e5dabe9b3
added :if and :unless conditionals to impressionist
2014-02-21 13:13:33 -08:00
1c3ac147aa
Bump to 1.5.1
2013-12-31 21:19:04 +00:00
M. Simon Borg
Jonas Grau
Felix Wolfsteller
John McAliley
Asaf Bartov
Torsten Ruger
John McAliley
Dmitry Yarikov
spodlecki
SengMing Tan
Jisu Park
asharma-ror
Md. Tauhidul Islam
zonkeynir
Qihuan Piao
Bashir Eghbali
Antonio C Nalesso