Dmitry Yarikov
a0fddc9072
Fix: wrong number of arguments (given 2, expected 0..1)
2016-07-08 11:42:33 +03:00
John McAliley
6e551927ec
Merge pull request #208 from spodlecki/removing-httpclient
...
Remove httpclient due to deprecation warning for #timeout
2016-02-02 19:28:34 -05:00
spodlecki
14794f8e34
travis updates and gemfile test for travis
2015-12-30 16:54:57 -06:00
spodlecki
b38845ac6f
removing httpclient due to deprecation warning
2015-12-30 16:40:05 -06:00
John McAliley
aae429286d
Merge pull request #202 from tansengming/feature/updates-nokogiri
...
updates nokogiri
2015-12-03 09:23:03 -05:00
SengMing Tan
abe390113f
updates nokogiri
2015-11-04 13:16:59 +11:00
John McAliley
729e4fca3b
Merge pull request #188 from asharma-ror/params_feature
...
Params feature
2015-06-24 22:18:11 -04:00
John McAliley
ae01d1ccb8
Merge pull request #189 from JisuPark/patch-1
...
Typing error corrected
2015-06-24 22:16:08 -04:00
Jisu Park
81a9c5f022
Typos corrected
...
impressionalble => impressionable
2015-04-23 15:33:49 +09:00
asharma-ror
04d80ef172
Fixed the failing case.
2015-04-22 11:08:10 +05:30
asharma-ror
8c3407fd33
Adding params field to migration file.
2015-04-22 10:43:47 +05:30
asharma-ror
9d997bc600
readme for params feature
2015-04-21 15:55:37 +05:30
asharma-ror
2e72b5aefa
params feature
2015-04-21 15:51:47 +05:30
John McAliley
432b77e40d
Merge pull request #182 from tauhidul35/master
...
Unique impressionist of a instance which is using friendly_id
2015-02-09 20:21:13 -05:00
Md. Tauhidul Islam
66c7533f47
- Fix test code for unique impressionist of instance with friendly_id
...
- Fixed rspec-rails version for run previous test cases
- Add friendly_id in gemfiles for run test case
2015-02-08 02:03:34 +06:00
Md. Tauhidul Islam
5573aebeaa
Change friendly_id gem version
2015-02-08 00:54:41 +06:00
Md. Tauhidul Islam
8573b40e6f
Add friendly_id to test group in gem file
2015-02-08 00:43:38 +06:00
Md. Tauhidul Islam
f77d187f66
Unique impressionist count for objects which are using friendly_id
2015-02-07 22:08:32 +06:00
John McAliley
cacdd66fd8
Merge pull request #154 from zonkeynir/master
...
Issue for mongoid
2014-04-30 15:51:25 -04:00
John McAliley
af3466a0c3
Merge pull request #151 from kinopyo/patch-2
...
Update README.md for #impressionist method
2014-04-30 15:49:52 -04:00
John McAliley
aa27664381
Merge pull request #150 from kinopyo/patch-1
...
Update README.md for usage with friendly_id
2014-04-30 15:48:17 -04:00
zonkeynir
c69437bfff
Issue for mongoid
...
Queries is always on ObjectId type of imperssion_id, while model not restricts the type.
Thats can cause to saves in String format, hence not imperssions will be counted on counter_cache
2014-04-28 17:50:14 +03:00
Qihuan Piao
d93dd0e356
Update README.md for #impressionist method
...
A quick fix for https://github.com/charlotte-ruby/impressionist/issues/138
2014-04-17 17:12:48 +09:00
Qihuan Piao
2bb18c0d95
Update README.md for usage with friendly_id
2014-04-17 17:03:48 +09:00
John McAliley
cb0002a7d2
Merge pull request #144 from beghbali/master
...
added :if and :unless conditionals to impressionist
2014-03-25 22:01:00 -04:00
Bashir Eghbali
d157b1feff
fixed specs
2014-02-21 16:09:57 -08:00
Bashir Eghbali
38ece35eb7
fixed tests + added tests for conditionals
2014-02-21 16:00:15 -08:00
Bashir Eghbali
78a35925b2
cleaned up the logic. too much double negative
2014-02-21 15:32:07 -08:00
Bashir Eghbali
2e5dabe9b3
added :if and :unless conditionals to impressionist
2014-02-21 13:13:33 -08:00
Antonio C Nalesso
1c3ac147aa
Bump to 1.5.1
2013-12-31 21:19:04 +00:00
Antonio C Nalesso Moreira
71b081c749
Merge pull request #136 from geoffharcourt/geoffharcourt-issue_135
...
Only define Impressionable::ClassMethods::DEFAULT_CACHE when undefined
2013-12-31 13:19:21 -08:00
Geoff Harcourt
ed00e3ffe2
Use more concise declaration of DEFAULT_CACHE
...
In response to @acnalesso’s notes on
e3f86c8051
, using ||= to make assignment
of Impressionable::ClassMethods::DEFAULT_CACHE more concise, avoiding a
call to #defined? when checking to see if the constant has been
declared.
2013-12-31 14:51:24 -05:00
Antonio C Nalesso
24a93e8bcb
Bump to 1.5.0
2013-12-30 17:55:38 +00:00
Antonio C Nalesso Moreira
22e46f6b3b
Update CHANGELOG.rdoc
2013-12-30 17:52:11 +00:00
Antonio C Nalesso Moreira
c8ed56b365
Merge pull request #133 from overovermind/master
...
Add functionality to count only specific messages
2013-12-30 09:48:37 -08:00
Geoff Harcourt
e3f86c8051
Only define Impressionable::ClassMethods::DEFAULT_CACHE when undefined
...
Current behavior causes unnecessary warning messages to be issued when
using Impressionist with application preloaders such as spring.
2013-12-28 15:01:39 -05:00
Hannes Staffler
3494a040a2
updated readme
2013-12-13 10:39:14 +01:00
Hannes Staffler
bad17466ee
added functionality to filter by message
2013-12-13 10:20:20 +01:00
Erik Michaels-Ober
a974bd85b3
Opt-out of build email notifications [ci skip]
2013-11-29 10:57:32 +01:00
Erik Michaels-Ober
428e0eb84f
Update test app dependencies
2013-11-29 10:36:05 +01:00
Erik Michaels-Ober
f5c19a535b
Consistently use pessimistic comparison operator
2013-11-29 10:36:05 +01:00
Erik Michaels-Ober
576cd0a8d7
Move development dependencies into Gemfile
2013-11-29 10:36:02 +01:00
Erik Michaels-Ober
a4e9e84d66
Enable fast finishing builds
2013-11-29 07:09:21 +01:00
Antonio C Nalesso
ddb1a91c53
Bump to 1.4.13
2013-11-28 17:36:32 +00:00
Antonio C Nalesso Moreira
95faf9cece
Merge pull request #130 from blarralde/patch-1
...
Allow nokogiri 1.6
2013-11-28 09:35:56 -08:00
Benjamin Larralde
522ef7b239
Fix syntax for nokogiri version
2013-11-27 17:51:46 -08:00
Benjamin Larralde
f666bc7a35
Allow nokogiri 1.6
2013-11-27 17:46:46 -08:00
Antonio C Nalesso Moreira
dc5def484c
Fix maintainer name
2013-10-28 20:19:11 +00:00
Antonio C Nalesso Moreira
306793984b
Bump to 1.4.12
2013-10-28 20:16:28 +00:00
Antonio C Nalesso Moreira
0ff7a09e82
Merge pull request #128 from barodeur/fix_mongoid_filter_not_defined
...
Fix Mongoid undefined 'filter' error
2013-10-28 13:14:00 -07:00