Geoff Harcourt
ed00e3ffe2
Use more concise declaration of DEFAULT_CACHE
...
In response to @acnalesso’s notes on
e3f86c8051
, using ||= to make assignment
of Impressionable::ClassMethods::DEFAULT_CACHE more concise, avoiding a
call to #defined? when checking to see if the constant has been
declared.
2013-12-31 14:51:24 -05:00
Geoff Harcourt
e3f86c8051
Only define Impressionable::ClassMethods::DEFAULT_CACHE when undefined
...
Current behavior causes unnecessary warning messages to be issued when
using Impressionist with application preloaders such as spring.
2013-12-28 15:01:39 -05:00
Erik Michaels-Ober
a974bd85b3
Opt-out of build email notifications [ci skip]
2013-11-29 10:57:32 +01:00
Erik Michaels-Ober
428e0eb84f
Update test app dependencies
2013-11-29 10:36:05 +01:00
Erik Michaels-Ober
f5c19a535b
Consistently use pessimistic comparison operator
2013-11-29 10:36:05 +01:00
Erik Michaels-Ober
576cd0a8d7
Move development dependencies into Gemfile
2013-11-29 10:36:02 +01:00
Erik Michaels-Ober
a4e9e84d66
Enable fast finishing builds
2013-11-29 07:09:21 +01:00
Antonio C Nalesso
ddb1a91c53
Bump to 1.4.13
2013-11-28 17:36:32 +00:00
Antonio C Nalesso Moreira
95faf9cece
Merge pull request #130 from blarralde/patch-1
...
Allow nokogiri 1.6
2013-11-28 09:35:56 -08:00
Benjamin Larralde
522ef7b239
Fix syntax for nokogiri version
2013-11-27 17:51:46 -08:00
Benjamin Larralde
f666bc7a35
Allow nokogiri 1.6
2013-11-27 17:46:46 -08:00
Antonio C Nalesso Moreira
dc5def484c
Fix maintainer name
2013-10-28 20:19:11 +00:00
Antonio C Nalesso Moreira
306793984b
Bump to 1.4.12
2013-10-28 20:16:28 +00:00
Antonio C Nalesso Moreira
0ff7a09e82
Merge pull request #128 from barodeur/fix_mongoid_filter_not_defined
...
Fix Mongoid undefined 'filter' error
2013-10-28 13:14:00 -07:00
Paul Chobert
450f04dd66
Fix Mongoid filter error
...
```NameError: undefined local variable or method `filter'```
2013-10-28 19:05:04 +01:00
Antonio C Nalesso Moreira
5e6aebec1f
Support Nokogiri < 1.6 see issue #124
2013-10-28 17:56:46 +00:00
Antonio C Nalesso Moreira
fb535b29f7
Merge branch 'master' of https://github.com/charlotte-ruby/impressionist
...
Johnmcaliley - added code climate and changes to contributors.
2013-10-28 17:54:29 +00:00
Antonio C Nalesso Moreira
c817a648a3
Bump to 1.4.11
2013-10-28 17:54:09 +00:00
jd pagano
a3a44a88fd
Refactor impressionist_count method in impressionable.rb method to be more human readable
2013-10-28 17:54:09 +00:00
John McAliley
15fbb76f88
added code climate and changes to contributors
2013-10-18 16:32:15 -04:00
Antonio C Nalesso Moreira
2807ba4ee9
Merge pull request #121 from joofsh/refactor_impressionable_impressionist_count_for_mongoid
...
Refactor override of impressionist_count for mongoid compatibility
2013-10-11 01:56:59 -07:00
jd pagano
b8719206ff
Refactor override of impressionist_count for mongoid compatibility to fit the same style as the default AR version
2013-10-10 19:31:57 -04:00
Antonio C Nalesso Moreira
2b0fc9e572
Bump to 1.4.11
2013-10-10 23:06:30 +01:00
Antonio C Nalesso Moreira
cbece83ac9
Merge pull request #120 from joofsh/Refactor_impressionable_impressionist_count_method
...
Refactor impressionist_count method in impressionable.rb
2013-10-10 15:00:35 -07:00
jd pagano
c054fe6b02
Refactor impressionist_count method in impressionable.rb method to be more human readable
2013-10-10 16:29:46 -04:00
Antonio C Nalesso Moreira
13cda5c508
Bump to 1.4.10
2013-09-30 20:48:08 +01:00
Antonio C Nalesso Moreira
2b4db0001d
Merge pull request #116 from DouglasSherk/master
...
Fix startup crash with Mongoid wrapper.
2013-09-30 12:46:37 -07:00
DouglasSherk
483ea9ea9c
Fix startup crash with Mongoid wrapper.
2013-09-30 14:02:47 -04:00
Antonio C Nalesso Moreira
6f74e58068
Bump to 1.4.9
2013-09-23 02:55:24 +01:00
Antonio C Nalesso Moreira
07183f6f71
Merge pull request #114 from petergoldstein/feature/add_strong_parameters_support
...
Don't include attr_accessible if StrongParameters is in use.
2013-09-22 18:52:37 -07:00
Antonio C Nalesso Moreira
ccc7ac7a0b
Merge pull request #113 from petergoldstein/feature/make_associative_create_hash_protected
...
Make associative_create_statement protected rather than private
2013-09-22 18:47:57 -07:00
Antonio C Nalesso Moreira
3cf6b2597e
Merge pull request #115 from petergoldstein/feature/rails_4_and_travis
...
Travis Ci Update - Rails 4, Ruby 2.0, JRuby
2013-09-22 18:46:00 -07:00
Peter M. Goldstein
28298d578f
Add Rails 4 as a permitted dependency. Add Rails 4 to the test matrix. Remove Ruby 1.8.x from test matrix because specs were failing anyway because of capybara dependency. Add JRuby to the test matrix and neaten up the JRuby dependencies.
2013-09-22 13:34:20 -07:00
Peter M. Goldstein
68ea36a7fe
Make associative_create_statement protected rather than private, so it can be accessed by subclasses. This makes it easy for subclasses to add custom fields to the impression.
2013-09-22 11:43:59 -07:00
Peter M. Goldstein
67acf817d2
Don't use attr_accessible if StrongParameters is included in the application.
2013-09-22 11:37:28 -07:00
Antonio C Nalesso Moreira
6ff77290f2
fix travis failing, added entries to CHANGELOG
2013-09-09 00:34:01 +01:00
Antonio C Nalesso Moreira
d17986f098
fix travis failing
2013-09-06 23:07:47 +01:00
Antonio C Nalesso Moreira
3d23031a31
removed sqlite3 dependency as it causes heroku to fail [ci skip]
2013-09-06 02:25:34 +01:00
Antonio C Nalesso Moreira
34df3e88b3
Bump to 1.4.8
2013-09-02 02:24:53 +01:00
Antonio C Nalesso Moreira
d42819dd42
FIX #108 , this is what happens when I should had gone to sleep :)
2013-09-02 02:23:52 +01:00
Antonio C Nalesso Moreira
1edd378cc0
clean up [ci skip]
2013-08-31 00:57:08 +01:00
Antonio C Nalesso Moreira
8fed516142
Bump to 1.4.7 [ci skip]
2013-08-31 00:46:05 +01:00
Antonio C Nalesso Moreira
60044695f9
Bump to 1.4.7
2013-08-31 00:37:17 +01:00
Antonio C Nalesso Moreira
c9ae78d92a
FIX #103 , changed constantize for safe_constantize
2013-08-31 00:28:20 +01:00
Antonio C Nalesso Moreira
3839dbbf41
FIX #104 , wrong documentation
2013-08-22 21:42:21 +01:00
Antonio C Nalesso Moreira
55dd2dfb1f
Bump to 1.4.6
2013-08-18 00:04:05 +01:00
Antonio C Nalesso Moreira
0bb4a41ad0
Merge pull request #106 from Linuus/master
...
Count unique records in Rails 4
2013-08-17 16:00:19 -07:00
Linus Pettersson
acef02935c
Check for version 4 instead of 3
2013-08-16 23:42:03 +02:00
Linus Pettersson
36eb6cacb2
Fixed unique count for Rails 4
2013-08-16 23:37:30 +02:00
Antonio C Nalesso Moreira
93f7c6bc2f
Update CHANGELOG.rdoc
2013-07-21 01:35:39 +01:00